build: delete both browser-extension packages and their shared build/CI/npm-script wiring#8603
Merged
Merged
Conversation
Closes #8597, first of the browser-extension removal epic's three sequenced sub-issues (#8596). Lands before the package itself is deleted (next sub-issue) so the "Download extension" button and its download page disappear before the zip they point at stops being generated -- never the other way around, which would leave a live broken download link on the public site. Removes the dedicated /extension route and its test, both nav links (site footer, command palette), the sitemap entry, and the README table row. Reworded roadmap.tsx's Phase 2 entry to drop the browser- extension framing while keeping its real remaining scope (maintainer trust checklist, install health, private/public rendering checks) -- swapped its "Open extension page" link for /app/maintainer, a route that already covers install health and maintainer controls, rather than just deleting the link outright. maintainer-install-trust.mdx needed more than the single section the original file-level grep found: removed the "## Browser extension states" section (heading through its code block and the screenshot- requirement sentence immediately after it), the "Extension sessions are scoped..." audit-expectations bullet, and the "Browser extension" cross-link in the closing paragraph -- also reworded the "Reject UI or extension PRs" bullet to just "Reject UI PRs" since that rule was never extension-specific. self-hosting-operations.mdx's "extension block" mention is a false positive (Docker Compose's `x-` extension fields, unrelated) -- left unchanged after verifying context, per the issue's own explicit instruction not to assume. routeTree.gen.ts regenerated via a real `npm --workspace @loopover/ui run build`, not hand-edited. Validated: typecheck clean, ui:lint 0 errors, ui:test 86 files/571 tests passing, docs:drift-check clean.
…CI/npm-script wiring Closes #8598. Second of three sequenced sub-issues under the browser- extension removal epic (#8596) -- lands after the UI download surface is gone (#8597) and before the backend API routes (#8599, next). Deletes apps/loopover-extension/ and apps/loopover-miner-extension/ wholesale, scripts/build-extension.ts, scripts/build-miner-extension.ts, and scripts/extension-zip-core.ts (verified only those two build scripts + the now-deleted test referenced it). Deletes 10 root-level tests that read the app directories' raw source directly -- 9 named in the issue's own audit, plus test/unit/miner-toolbar-badge.test.ts, which the original audit missed and would have ENOENT'd immediately. Trims (does not delete) codecov-policy.test.ts's shared coverage-gate test down to miner-ui only. Removes all shared build/CI wiring in one PR, as required (turbo.json's 5 task blocks + the ui#build dependsOn edge + //#typecheck's inputs; ci.yml's path filters, the 3 dedicated steps, and every stale comment mention; ui-deploy.yml's Validate-frontend chain; root package.json's 6 scripts + the ui:build/ui:test chains; .gitignore's dead zip entry). Beyond the issue's own file-level-grep audit, a full repo-wide sweep turned up more real references that would have silently broken or gone stale: two production smoke-test scripts (smoke-production.ts, smoke-ui-browser.ts) still probing the now-gone /extension route and zip download -- these would have started failing in production the moment #8597 merged; scripts/mcp-release-core.ts and scripts/orb-release-core.ts's UI/excluded-path arrays still listing the deleted directories; and several comments across packages/loopover-miner/lib/ and apps/loopover-miner-ui/ describing the extension as a consumer of the ranked-candidates API and discover snapshot -- reworded to describe their real remaining consumer (miner-ui's own dashboard) instead of leaving them referencing a deleted package. Left alone, correctly out of scope: src/openapi/ spec.ts and src/signals/extension-contributor-context.ts (src/**, #8599's territory), packages/loopover-mcp/CHANGELOG.md (immutable history), and every genuine "file extension"/"OAuth scope extension" false positive a broad grep surfaced. package-lock.json regenerated via real npm install/ci, not hand- edited, with one narrow exception: two "extraneous": true workspace stub entries that persisted across five different npm-tool-driven attempts (repeated install, prune, full clean reinstall) even after confirming via `npm ci` that they carry zero real dependency resolution and have zero effect on install correctness -- traced to gitignored build leftovers (dist/, coverage/, node_modules/, .turbo/) that `git rm` doesn't touch, which kept the directories technically present for npm's workspace glob after the tracked files were gone. Removed those leftover directories too, alongside the two dead JSON stubs npm's own tooling had already flagged as not real. Validated: npm ci clean, npx turbo run build --filter=@loopover/ui succeeds with exactly 2 tasks (engine + ui, no extension task in the graph), package-lock.json has zero remaining extension references, node_modules has zero @loopover/{extension,miner-extension} entries. Full npm run test:ci left to GitHub Actions rather than a local run.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | a73731c | Commit Preview URL Branch Preview URL |
Jul 25 2026, 04:32 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8603 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 796 796
Lines 79855 79855
Branches 24136 24136
=======================================
Hits 73905 73905
Misses 4804 4804
Partials 1146 1146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bundle ReportChanges will decrease total bundle size by 25.98kB (-0.35%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: loopover-uiAssets Changed:
|
loopover-orb
Bot
added
the
gittensor:bug
Contributor
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-25 04:47:42 UTC
Review summary Nits — 6 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
…openapi.test.ts The prior commit on this branch simplified ui-deploy.yml's "Validate frontend" run command after deleting the extension packages, but left this test's hardcoded expected string pointing at the old extension/miner-extension lint/typecheck/build chain, failing validate-tests in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8598. Second of three sequenced sub-issues under the browser-extension removal epic (#8596) — lands after the UI download surface is gone (#8597, merged) and before the backend API routes (#8599, next, blocked on this).
Changes
apps/loopover-extension/andapps/loopover-miner-extension/wholesale,scripts/build-extension.ts,scripts/build-miner-extension.ts, andscripts/extension-zip-core.ts(verified only those two build scripts + the now-deleted test referenced it)test/unit/miner-toolbar-badge.test.ts, which the original audit missed and would have ENOENT'd immediatelycodecov-policy.test.ts's shared coverage-gate test down to miner-ui onlyturbo.json's 5 task blocks + theui#builddependsOn edge +//#typecheck's inputs;ci.yml's path filters, 3 dedicated steps, and every stale comment mention;ui-deploy.yml's Validate-frontend chain; rootpackage.json's 6 scripts +ui:build/ui:testchains;.gitignore's dead zip entryBeyond the issue's own audit
A full repo-wide sweep (not just the file-level grep the issue was scoped from) turned up more real references that would have silently broken or gone stale:
smoke-production.ts,smoke-ui-browser.ts) still probing the now-gone/extensionroute and zip download — these would have started failing in production the moment ui: remove the maintainer-extension's public UI surface (route, nav, docs, download link) #8597 mergedscripts/mcp-release-core.ts/scripts/orb-release-core.ts's UI/excluded-path arrays still listing the deleted directoriespackages/loopover-miner/lib/andapps/loopover-miner-ui/describing the extension as a consumer of the ranked-candidates API and discover snapshot — reworded to describe their real remaining consumer (miner-ui's own dashboard) instead of referencing a deleted packageLeft alone, correctly out of scope:
src/openapi/spec.tsandsrc/signals/extension-contributor-context.ts(src/**, #8599's territory),packages/loopover-mcp/CHANGELOG.md(immutable history), and every genuine "file extension"/"OAuth scope extension" false positive a broad grep surfaced.package-lock.json
Regenerated via real
npm install/npm ci, not hand-edited, with one narrow exception: two"extraneous": trueworkspace stub entries that persisted across five different npm-tool-driven attempts (repeated install, prune, full clean reinstall) even after confirming vianpm cithat they carry zero real dependency resolution and zero effect on install correctness. Traced the root cause: gitignored build leftovers (dist/,coverage/,node_modules/,.turbo/) thatgit rmdoesn't touch, which kept the directories technically present for npm's workspace glob after the tracked files were gone. Removed those leftover directories, then removed the two dead JSON stubs npm's own tooling had already flagged as not real.Validation
npm ci: cleannpx turbo run build --filter=@loopover/ui: succeeds with exactly 2 tasks (engine + ui) — zero extension task in the build graphpackage-lock.json: zero remaining extension references;node_modules: zero@loopover/{extension,miner-extension}entriesnpm run test:cileft to GitHub Actions rather than a local run