fix(docs): add the 6 missing published docs pages to the DocsNav sidebar#8508
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
miner-quickstart, loopover-commands, ai-summaries, owner-checklist, self-hosting-docs-audit, and self-hosting-unified-ams-orb all have published, cross-linked content/docs/*.mdx pages but no docsNav entry, so they were unreachable from the persistent sidebar and skipped by DocsPrevNext. Adds a drift guard so a future page that forgets its entry fails a test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-24 16:47:46 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|


Fixes #8385
Re-file of #8501, which failed the
changesjob's whitespace step for a reason unrelated to its contents: the check runsgit diff --check <base.sha> HEAD, and main had advanced past my branch point between syncing and filing. The diff therefore included the reverse of other merged commits, andgit diff --checkflagged CRLF line endings insrc/review/inline-comment-range.ts— a file this PR does not touch. This branch is cut from currentmain(d09fbe22), so the diff is exactly the 2 files below andgit diff --checkpasses clean. Code is unchanged from #8476, which reviewed atno blockers/readiness 93/100.Summary
docsNav(apps/loopover-ui/src/components/site/docs-nav.tsx) is hand-maintained alongsidedocs.index.tsx's separate landing grid. Six published pages had realcontent/docs/*.mdxcontent and index links but no sidebar entry:miner-quickstart,loopover-commands,ai-summaries,owner-checklist,self-hosting-docs-audit,self-hosting-unified-ams-orb.DocsPrevNextbuilds its footer links from the same array viagroupItems(), so those pages were unreachable from the left rail and skipped in the prev/next reading flow.UI Evidence
Captured on
/docs/miner-quickstart(one of the six) at fixed viewports, dark theme — the build is dark-mode-only. Before shows the sidebar with no entry for the page being viewed and nothing highlighted; after shows it listed and active.Scope
Additive only — no existing entry removed or reordered. Each page placed in the group the issue specifies, reusing
docs.index.tsx's established label:miner-quickstartloopover-commandsai-summariesself-hosting-unified-ams-orbself-hosting-docs-auditowner-checklistself-hosting-docs-auditwent to release & security rather than setup because its frontmatter describes a pre-release accuracy checklist, next to the existing "Release checklist".docs.index.tsxis deliberately untouched, per the issue.Drift guard
New
docs-nav.test.tsx, co-located per convention, reading real files asdocs-source-server-isolation.test.tsalready does.content/docs/is the source of truth:.mdxhas a sidebar entry (the regression)It genuinely fails pre-fix: stashing only the
docs-nav.tsxchange reports exactly the 6 missing slugs; restoring it passes 4/4.Validation
npm --workspace @loopover/ui run test -- src/components/site/docs-nav.test.tsx— 4/4, re-run after rebasing ontod09fbe22(the guard asserts against the livecontent/docs/directory, so a doc page added upstream would break it)npm --workspace @loopover/ui run typecheck— clean;prettier --checkclean on both filesgit diff --check upstream/main HEAD— cleanapps/**is outside Codecov'scoverage.include, so no patch percentage applies