chore(ci): rename self-host-nightly.yml to self-host-maintenance.yml#8483
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
The workflow has no schedule: trigger -- workflow_dispatch is its only one, and its own header says that is deliberate while the review stack runs without colocated runners. Its name: field already reads "self-host maintenance"; only the filename still implied an unattended nightly job, which is misleading when surveying .github/workflows/ by filename. Pure git rename: no content, trigger, or job changes. Nothing else in the repo referenced the old filename. Closes JSONbored#8397
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8483 +/- ##
===========================================
+ Coverage 66.08% 92.51% +26.42%
===========================================
Files 791 791
Lines 79333 79343 +10
Branches 23961 23967 +6
===========================================
+ Hits 52430 73403 +20973
+ Misses 22909 4807 -18102
+ Partials 3994 1133 -2861
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-24 15:48:43 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
.github/workflows/self-host-nightly.ymlhas noschedule:trigger —workflow_dispatch: {}is its only one, and the file's own header states that is deliberate ("deliberately not scheduled while the review stack is running without colocated GitHub Actions runners"). Itsname:field already readsself-host maintenance; only the filename still implied an unattended nightly job — a holdover from before #4899 generalized the workflow and dropped its schedule.That is misleading to anyone surveying
.github/workflows/by filename, which is the usual way to scan a repo's automation. Renamed toself-host-maintenance.yml, matching its ownname:field and this repo's convention of filename mirroringname:(e.g.stuck-check-watchdog.yml→Stuck required-check watchdog,cache-cleanup.yml→Clean up closed-PR caches).Pure rename —
git diff --statreports1 file changed, 0 insertions(+), 0 deletions(-)and git records it as a rename (R), so history is preserved. Noname:, trigger, job, or any other content change.I independently re-verified the issue's claim that nothing else references the old filename before renaming:
Closes #8397
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
typecheck,test:coverage,test:workers,build:mcp/test:mcp-pack,ui:*, andnpm auditare all unaffected.npm run actionlint(the check that does cover.github/workflows/**) passes, andgit diff --checkis clean.workflow_dispatch-only workflow, and the workflow body is byte-identical. The meaningful verification is the grep above proving no reference breaks, plus actionlint still accepting the file at its new path.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable — a workflow-file rename; no visible UI, frontend, docs, or extension change.
Notes
workflow_dispatch-only operator hook with no schedule this is a cosmetic, one-time effect; flagging it explicitly since it is the only externally visible consequence of the rename.