Migrate Dangerfile back to Kotlin by JordanLongstaff · Pull Request #483 · JPL-Software-Solutions/ArtemisAgent

JordanLongstaff · 2025-10-31T04:36:12Z

Another attempt to get rid of Ruby in this repo.
Tentative on the release of an Android Lint plugin that actually works with Danger Kotlin, if that ever happens.

github-actions · 2025-10-31T04:39:17Z

No dependency violations found. 👍

github-actions · 2025-10-31T04:57:02Z

Code Coverage (IAN/udp)

Total Project Coverage	100.00%	✅

github-actions · 2025-10-31T04:59:03Z

Code Coverage (IAN/enums)

Total Project Coverage	100.00%	✅

github-actions · 2025-10-31T05:09:48Z

Code Coverage (IAN/world)

Total Project Coverage	99.43%	✅

github-actions · 2025-10-31T05:10:22Z

Code Coverage (IAN/vesseldata)

Total Project Coverage	98.73%	❌

github-actions · 2025-10-31T05:10:58Z

Unit Test Results

140 files ±0 140 suites ±0 21m 13s ⏱️ - 1m 11s
1 362 tests ±0 1 362 ✅ ±0 0 💤 ±0 0 ❌ ±0
4 001 runs ±0 4 001 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 1eb3c11. ± Comparison against base commit 9456448.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-31T05:11:11Z

Konsist Test Results

12 files ±0 12 suites ±0 8s ⏱️ -1s
128 tests ±0 128 ✅ ±0 0 💤 ±0 0 ❌ ±0
701 runs ±0 701 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 1eb3c11. ± Comparison against base commit 9456448.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-31T05:36:12Z

Instrumented Test Results

0 files - 28 0 suites - 28 0s ⏱️ - 7h 25m 9s
0 tests - 39 0 ✅ - 28 0 💤 ±0 0 ❌ - 11
0 runs - 1 038 0 ✅ - 1 019 0 💤 ±0 0 ❌ - 19

Results for commit 1eb3c11. ± Comparison against base commit 9456448.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-31T15:09:49Z

Code Coverage (app)

Total Project Coverage	13.68%	❌

github-actions · 2025-10-31T15:19:30Z

Code Coverage (IAN/packets)

File	Coverage [100.00%]
IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt	100.00%

Total Project Coverage	99.14%	✅

github-actions · 2025-10-31T15:30:32Z

Code Coverage (IAN/util)

Total Project Coverage	100.00%	✅

github-actions · 2025-11-01T15:39:14Z

Code Coverage (IAN/listener)

Total Project Coverage	100.00%	✅

github-actions · 2025-11-01T15:53:22Z

Code Coverage (IAN)

Total Project Coverage	97.75%	❌

github-actions · 2025-11-01T16:14:22Z

Total Code Coverage

File	Coverage [100.00%]
IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt	100.00%

Total Project Coverage	89.86%	❌

# Conflicts: # .github/workflows/danger.yml # Gemfile.lock

    @OptIn(ExperimentalTime::class)
    @Throws(PacketException::class)
    suspend fun readPacket(): ParseResult {
+        if (false) {}


JordanLongstaff · 2025-11-03T06:00:02Z

	Warnings
⚠️	IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt#L47 - Detekt: Class 'PacketReader' with '35' functions detected. Defined threshold inside classes is set to '11', rule: detekt.TooManyFunctions
⚠️	IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt#L89 - Detekt: Function readPacket has 3 return statements which exceeds the limit of 2., rule: detekt.ReturnCount
⚠️	IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt#L90 - Detekt: This empty block of code can be removed., rule: detekt.EmptyIfBlock
⚠️	app/src/main/kotlin/artemis/agent/AgentViewModel.kt#L98 - Detekt: Class 'AgentViewModel' with '34' functions detected. Defined threshold inside classes is set to '11', rule: detekt.TooManyFunctions
⚠️	app/src/main/kotlin/artemis/agent/AgentViewModel.kt#L98 - Detekt: Class AgentViewModel is too large. Consider splitting it into smaller pieces., rule: detekt.LargeClass
⚠️	app/src/main/kotlin/artemis/agent/AgentViewModel.kt#L683 - Detekt: The function updateObjects appears to be too complex based on Cognitive Complexity (complexity: 91). Defined complexity threshold for methods is set to '15', rule: detekt.CognitiveComplexMethod
⚠️	app/src/main/kotlin/artemis/agent/AgentViewModel.kt#L683 - Detekt: The function updateObjects appears to be too complex based on Cyclomatic Complexity (complexity: 69). Defined complexity threshold for methods is set to '15', rule: detekt.CyclomaticComplexMethod
⚠️	app/src/main/kotlin/artemis/agent/AgentViewModel.kt#L683 - Detekt: The function updateObjects is too long (228). The maximum length is 60., rule: detekt.LongMethod
⚠️	app/src/main/kotlin/artemis/agent/cpu/RoutingGraph.kt#L291 - Detekt: Function calculateAvoidanceRouteCost has 5 return statements which exceeds the limit of 2., rule: detekt.ReturnCount
⚠️	app/src/main/kotlin/artemis/agent/cpu/RoutingGraph.kt#L291 - Detekt: The function calculateAvoidanceRouteCost appears to be too complex based on Cognitive Complexity (complexity: 85). Defined complexity threshold for methods is set to '15', rule: detekt.CognitiveComplexMethod
⚠️	app/src/main/kotlin/artemis/agent/cpu/RoutingGraph.kt#L291 - Detekt: The function calculateAvoidanceRouteCost appears to be too complex based on Cyclomatic Complexity (complexity: 38). Defined complexity threshold for methods is set to '15', rule: detekt.CyclomaticComplexMethod
⚠️	app/src/main/kotlin/artemis/agent/cpu/RoutingGraph.kt#L291 - Detekt: The function calculateAvoidanceRouteCost is too long (168). The maximum length is 60., rule: detekt.LongMethod
⚠️	app/src/main/kotlin/artemis/agent/cpu/RoutingGraph.kt#L347 - Detekt: The loop contains more than one break or continue statement. The code should be refactored to increase readability., rule: detekt.LoopWithTooManyJumpStatements

	Messages
📖	`All modified files: .github/workflows/codeql.yml DiffForFile(file=.github/workflows/codeql.yml, additions=[], deletions=[])` .github/workflows/danger.yml DiffForFile(file=.github/workflows/danger.yml, additions=[], deletions=[]) .tool-versions DiffForFile(file=.tool-versions, additions=[], deletions=[]) IAN/packets/detekt-baseline.xml DiffForFile(file=IAN/packets/detekt-baseline.xml, additions=[], deletions=[]) IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt DiffForFile(file=IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt, additions=[], deletions=[]) app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml DiffForFile(file=app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml, additions=[], deletions=[]) app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml DiffForFile(file=app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml, additions=[], deletions=[]) renovate.json DiffForFile(file=renovate.json, additions=[], deletions=[]) Dangerfile.df.kts DiffForFile(file=Dangerfile.df.kts, additions=[], deletions=[]) danger/baselines.df.kts DiffForFile(file=danger/baselines.df.kts, additions=[], deletions=[]) danger/main-no-tests.df.kts DiffForFile(file=danger/main-no-tests.df.kts, additions=[], deletions=[]) danger/max-lines.df.kts DiffForFile(file=danger/max-lines.df.kts, additions=[], deletions=[]) danger/wip.df.kts DiffForFile(file=danger/wip.df.kts, additions=[], deletions=[])

Generated by 🚫 Danger Kotlin against 1eb3c11

JordanLongstaff added 3 commits October 30, 2025 22:56

Migrate Dangerfile back to Kotlin

e6ff371

Cannot use Android Lint plugin for now

fd10eda

Merge branch 'main' into danger-kotlin

f25dd56

github-advanced-security AI found potential problems Oct 31, 2025

View reviewed changes

JordanLongstaff added 3 commits October 31, 2025 10:35

Danger Kotlin only works on Ubuntu runner

a5d7689

Merge branch 'main' into danger-kotlin

d104602

Add diff parameters

6261c6e

Fix added line parsing

53df351

JordanLongstaff added 4 commits November 1, 2025 11:13

Merge branch 'main' into danger-kotlin

dcd273b

Fix error in Dangerfile.df.kts

a9842b9

Merge branch 'main' into danger-kotlin

90be314

Try another Detekt warning

25d05f3

github-advanced-security AI found potential problems Nov 1, 2025

View reviewed changes

Comment thread IAN/packets/src/main/kotlin/com/walkertribe/ian/iface/PacketReader.kt Fixed

Add warning message when diff numstat fails

8d7868f

JordanLongstaff added 2 commits November 3, 2025 00:32

Try using fork of Danger Kotlin

40f9e15

Merge branch 'main' into danger-kotlin

0264a8e

# Conflicts: # .github/workflows/danger.yml # Gemfile.lock

JordanLongstaff added 3 commits November 3, 2025 00:38

Fix Docker tag

7e4b6f6

Remove secret files?

4552c77

Try removing github workspace references

0d25749

github-advanced-security AI found potential problems Nov 3, 2025

View reviewed changes

JordanLongstaff added 2 commits November 3, 2025 00:55

Fix plugin registration

e3e5e82

Really fix plugin registration

5398d00

JordanLongstaff added 6 commits November 3, 2025 01:32

Use rule scripts

57a1a94

Add to detekt-baseline.xml

6f908d9

Add missing import

c113311

Add logging

1f2e309

Log addition counts

4557262

Report entire diff for file

1eb3c11

Conversation

JordanLongstaff commented Oct 31, 2025

Uh oh!

github-actions Bot commented Oct 31, 2025

Uh oh!

Check warning

Check warning

github-actions Bot commented Oct 31, 2025

Code Coverage (IAN/udp)

Uh oh!

github-actions Bot commented Oct 31, 2025

Code Coverage (IAN/enums)

Uh oh!

github-actions Bot commented Oct 31, 2025

Code Coverage (IAN/world)

Uh oh!

github-actions Bot commented Oct 31, 2025

Code Coverage (IAN/vesseldata)

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Konsist Test Results

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Instrumented Test Results

Uh oh!

github-actions Bot commented Oct 31, 2025

Code Coverage (app)

Uh oh!

github-actions Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage (IAN/packets)

Uh oh!

github-actions Bot commented Oct 31, 2025

Code Coverage (IAN/util)

Uh oh!

github-actions Bot commented Nov 1, 2025

Code Coverage (IAN/listener)

Uh oh!

Uh oh!

github-actions Bot commented Nov 1, 2025

Code Coverage (IAN)

Uh oh!

github-actions Bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Total Code Coverage

Uh oh!

Check warning

JordanLongstaff commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Oct 31, 2025 •

edited

Loading

github-actions Bot commented Oct 31, 2025 •

edited

Loading

github-actions Bot commented Oct 31, 2025 •

edited

Loading

github-actions Bot commented Oct 31, 2025 •

edited

Loading

github-actions Bot commented Nov 1, 2025 •

edited

Loading

JordanLongstaff commented Nov 3, 2025 •

edited

Loading