docs: add bilingual app installation guide#3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b537bba88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| xcodebuild -version >/dev/null 2>&1 || fail "Select a full Xcode installation with xcode-select." | ||
|
|
||
| print "Installing Agent Switch CLI..." | ||
| if ! pipx install --force "$ROOT"; then |
There was a problem hiding this comment.
Install with the Python version that was checked
The prerequisite test validates the python3 found on the shell PATH, but pipx install selects pipx's own default interpreter unless --python is supplied. On Macs where pipx is backed by an older Python while python3 resolves to 3.11+, this check passes and the subsequent installation fails because the project requires Python 3.11. Pass the validated interpreter to both pipx install invocations.
Useful? React with 👍 / 👎.
| PIPX_BIN_DIR="$(pipx environment --value PIPX_BIN_DIR)" | ||
| CLI="$PIPX_BIN_DIR/agent-switch" |
There was a problem hiding this comment.
Make the installed CLI discoverable by the app
When a user sets PIPX_BIN_DIR to a nondefault location, the installer successfully validates $PIPX_BIN_DIR/agent-switch here, but the installed app cannot use it: AgentSwitchService.findCLIPath searches only AGENT_SWITCH_CLI, ~/.local/bin, and two system paths. The app then falls back to python -m agent_switch, which is not installed into that system Python by this installer, so the launched app is nonfunctional. Either install/link the CLI in a path the app searches or pass/store the resolved CLI path for the app.
Useful? React with 👍 / 👎.
| agent-switch --version -> agent-switch 0.2.0 | ||
| agent-switch doctor --strict -> exits successfully with no managed drift | ||
| Native app -> opens from ~/Applications/Agent Switch.app | ||
| agent-switch --version -> agent-switch 0.2.0 |
There was a problem hiding this comment.
Document how to expose the pipx executable on PATH
For a normal new pipx installation, the executable is placed in ~/.local/bin, which is commonly absent from the current shell PATH. The installer verifies it through its absolute path, but the documented expected result and immediate next commands use bare agent-switch; those commands therefore fail in the same terminal after following brew install python pipx. Restore the pipx ensurepath/PATH guidance or show the resolved CLI path for these commands.
Useful? React with 👍 / 👎.
Summary
Verification