feat: unify MCP and secret management#1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 185b800fc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for name, value in preview.secrets.items(): | ||
| validate_secret(name, value) | ||
| for name, value in preview.secrets.items(): | ||
| set_secret(paths.secrets_file, name, value) |
There was a problem hiding this comment.
Write imports to the configured secret file
When a configuration sets secretFile to a non-default path, this import writes migrated values to paths.secrets_file instead of config.secret_file. The generated wrappers use config.secret_file, so mcp import --adopt removes the working native entry and replaces it with a wrapper that cannot find its migrated credentials; conflict detection also consults the wrong store. Use the loaded configuration's secret path for both reads and writes here.
Useful? React with 👍 / 👎.
Summary
Validation