Fix crash in avl_array (string table) on Playdate console#150
Merged
JBenda merged 1 commit intoMay 27, 2026
Conversation
…, 'char' making this explicit fixes memory corruption issues on some embedded arm devices like the Playdate
Ink Proof ResultsThese results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.
|
Owner
|
Thanks for the PR. It seems that implicit behavior will bite quite often. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
avl_arraytree structure expects the values in thebalance_array to be a signed to function correctly and causes memory corruption issues if it's not.The array type was changed from
std::uint8_ttocharhere #143 to avoid depending on STL, which makes senseThe issue is that on certain devices like the Playdate (Arm Cortex M7)
chardefaults to an unsigned type, this PR makes sure that the code is explicit in requiring a signed char and fixes the crash