Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/android-production-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
java-version: "17"

- name: Set up Android SDK
uses: android-actions/setup-android@v4
uses: android-actions/setup-android@40fd30fb8d7440372e1316f5d1809ec01dcd3699 # v4
with:
packages: ""

Expand All @@ -80,7 +80,7 @@ jobs:
sdkmanager "platform-tools" "platforms;android-36" "build-tools;36.1.0" "ndk;28.0.13004108"

- name: Set up Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2
with:
channel: stable
flutter-version: "3.41.9"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/flutter-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
uses: actions/checkout@v6

- name: Set up Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2
with:
channel: stable
flutter-version: "3.41.9"
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
java-version: "17"

- name: Set up Android SDK
uses: android-actions/setup-android@v4
uses: android-actions/setup-android@40fd30fb8d7440372e1316f5d1809ec01dcd3699 # v4
with:
packages: ""

Expand All @@ -154,7 +154,7 @@ jobs:
sdkmanager "platform-tools" "platforms;android-36" "build-tools;36.1.0" "ndk;28.0.13004108"

- name: Set up Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2
with:
channel: stable
flutter-version: "3.41.9"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/flutter-web-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
uses: actions/checkout@v6

- name: Set up Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2 # v2
with:
channel: stable
flutter-version: "3.41.9"
Expand Down
21 changes: 18 additions & 3 deletions test/scripts/release_guard_source_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ import 'dart:io';
import 'package:flutter_test/flutter_test.dart';

void main() {
const androidSetupAction =
'android-actions/setup-android@40fd30fb8d7440372e1316f5d1809ec01dcd3699';
const flutterAction =
'subosito/flutter-action@1a449444c387b1966244ae4d4f8c696479add0b2';

late String gradleBuild;
late String releasePreflight;
late String storeReleaseBuild;
Expand Down Expand Up @@ -2466,7 +2471,7 @@ SUPABASE_PUBLISHABLE_KEY=sb_publishable_abcdefghijklmnopqrstuvwxyz123456
});

test('ci installs Android SDK packages explicitly after setup-android', () {
expect(ciWorkflow, contains('android-actions/setup-android@v4'));
expect(ciWorkflow, contains(androidSetupAction));
expect(ciWorkflow, contains('packages: ""'));
expect(
ciWorkflow,
Expand All @@ -2476,7 +2481,7 @@ SUPABASE_PUBLISHABLE_KEY=sb_publishable_abcdefghijklmnopqrstuvwxyz123456
),
);
expect(
ciWorkflow.indexOf('android-actions/setup-android@v4'),
ciWorkflow.indexOf(androidSetupAction),
lessThan(ciWorkflow.indexOf('sdkmanager "platform-tools"')),
);
});
Expand All @@ -2491,8 +2496,18 @@ SUPABASE_PUBLISHABLE_KEY=sb_publishable_abcdefghijklmnopqrstuvwxyz123456
expect(workflow, isNot(contains('actions/upload-artifact@v4')));
}
expect(ciWorkflow, contains('actions/setup-java@v5'));
expect(ciWorkflow, contains('android-actions/setup-android@v4'));
expect(ciWorkflow, contains(androidSetupAction));
expect(androidProductionReleaseWorkflow, contains(androidSetupAction));
for (final workflow in [
ciWorkflow,
pagesWorkflow,
androidProductionReleaseWorkflow,
]) {
expect(workflow, contains(flutterAction));
expect(workflow, isNot(contains('subosito/flutter-action@v2')));
}
expect(ciWorkflow, isNot(contains('actions/setup-java@v4')));
expect(ciWorkflow, isNot(contains('android-actions/setup-android@v4')));
expect(ciWorkflow, isNot(contains('android-actions/setup-android@v3')));
});

Expand Down