Repository navigation
Frame the cover so no page crops into the app - #3
Merged
Merged
Conversation
The cover is now the real invoice view as a window on a soft background, with margin on every side, so the website and the in-app marketplace can crop it to their own shapes and only lose background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cover was a full-bleed crop of the app. Each place that shows it crops it to its own shape: 16:10 on the website module page, about 2:1 on the in-app cards. So the crop cut into the UI.
It's now the same real invoice view, captured from 3.0.0-alpha.13 with 0.1.0, framed as a window on a soft indigo background with margin on every side. Any of those crops only removes background. It stays at the same path, so the marketplace listing needs no change.