fix(e2e): strengthen concatenation protocol parameters - #3477
Merged
Conversation
Scale the two sets to k=274/m=420 and k=283/m=433 (phi_f 0.77) so a sub-quorum lottery draw can no longer create a blocking epoch gap.
jpraynaud
force-pushed
the
jpraynaud/3452-fix-e2e-flakiness
branch
2 times, most recently
from
August 7, 2026 12:47
3f92e89 to
e3556ab
Compare
jpraynaud
temporarily deployed
to
testing-preview
August 7, 2026 13:10 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-2-preview
August 7, 2026 13:10 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-preview
August 7, 2026 13:31 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-2-preview
August 7, 2026 13:31 — with
GitHub Actions
Inactive
* mithril-end-to-end from `0.5.11` to `0.5.12`
jpraynaud
force-pushed
the
jpraynaud/3452-fix-e2e-flakiness
branch
from
August 7, 2026 13:42
e3556ab to
54443f9
Compare
jpraynaud
marked this pull request as ready for review
August 7, 2026 13:42
There was a problem hiding this comment.
Pull request overview
This PR updates the Concatenation protocol parameters used by the mithril-end-to-end test harness to eliminate lottery-induced CI flakiness that can create an unrecoverable epoch gap (per issue #3452).
Changes:
- Increased the initial Concatenation protocol parameters used when starting the aggregator (
k=274, m=420, phi_f=0.77). - Increased the Concatenation protocol parameters applied during the protocol-parameters-change phase (
k=283, m=433, phi_f=0.77). - Bumped
mithril-end-to-endcrate version to0.5.12(and updatedCargo.lockaccordingly).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mithril-test-lab/mithril-end-to-end/src/toolkit/exec.rs | Scales the Concatenation protocol parameters applied during the runtime update phase. |
| mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs | Scales the initial Concatenation protocol parameters used when bootstrapping the aggregator in e2e infrastructure. |
| mithril-test-lab/mithril-end-to-end/Cargo.toml | Bumps the mithril-end-to-end crate version to reflect the parameter update. |
| Cargo.lock | Updates lockfile to align with the crate version bump. |
jpraynaud
temporarily deployed
to
testing-preview
August 7, 2026 14:00 — with
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-2-preview
August 7, 2026 14:00 — with
GitHub Actions
Inactive
Alenar
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a strengthening of the Concatenation protocol parameters used by the e2e tests to remove a lottery-induced flakiness in the CI.
Timeout exhausted waiting for Certificatefailures: withk=70, m=105, phi_f=0.77, the two signers together cover fewer thanklottery indexes in ~1 draw out of 177, and when this happens on the first open message of an epoch the aggregator ends the epoch without any certificate and blocks with an unrecoverable epoch gap.k=70, m=105, phi_f=0.77tok=274, m=420, phi_f=0.77.k=83, m=130, phi_f=0.75tok=283, m=433, phi_f=0.77.Benchmark on CI
Pre-submit checklist
Issue(s)
Relates to #3452