Skip to content

feat(common): updated the ed25519 dalek crate #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
damrobi wants to merge 2 commits into
base: main
Choose a base branch
from
+110 −22
Draft

feat(common): updated the ed25519 dalek crate #3473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
608e1af
feat(common): updated the ed25519 dalek crate and added a bridge to f…
damrobi Aug 5, 2026
2dfdccd
refactor(stm): removed bridge to replace with crate modif
damrobi Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 101 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion mithril-common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,16 @@ blake2 = "0.10.6"
chrono = { workspace = true }
ciborium = "0.2.2"
digest = { workspace = true }
ed25519-dalek = { version = "2.2.0", features = ["rand_core", "serde"] }
ed25519-dalek = { version = "3.0.0", features = ["rand_core", "serde"] }
fixed = "1.31.0"
getrandom = { version = "0.4", features = ["sys_rng"] }
hex = { workspace = true }
kes-summed-ed25519 = { version = "0.2.1", features = ["serde_enabled", "sk_clone_enabled"] }
mithril-merkle-tree = { path = "../internal/mithril-merkle-tree", version = "0.1.4" }
mithril-stm = { path = "../mithril-stm", version = "0.12.2", default-features = false }
nom = "8.0.0"
rand_chacha = { workspace = true }
rand_chacha_ed25519 = { package = "rand_chacha", version = "0.10.0" }
rand_core = { workspace = true }
rayon = { workspace = true }
semver = { workspace = true }
Expand Down
3 changes: 1 addition & 2 deletions mithril-common/src/crypto_helper/cardano/cold_key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use ed25519_dalek::SigningKey as ColdSecretKey;
use rand_chacha::ChaCha20Rng;
use rand_core::SeedableRng;
use rand_chacha_ed25519::{ChaCha20Rng, rand_core::SeedableRng};

/// A cold key generator / test only
#[doc(hidden)]
Expand Down
9 changes: 5 additions & 4 deletions mithril-common/src/crypto_helper/ed25519.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
//! Ed25519 cryptographic helpers

use anyhow::anyhow;
use ed25519_dalek::rand_core::{CryptoRng, UnwrapErr};
use ed25519_dalek::{Signer, SigningKey};
use rand_chacha::ChaCha20Rng;
use rand_chacha::rand_core::{CryptoRng, RngCore, SeedableRng};
use getrandom::SysRng;
use rand_chacha_ed25519::{ChaCha20Rng, rand_core::SeedableRng};
use serde::{Deserialize, Serialize};
use thiserror::Error;

Expand Down Expand Up @@ -35,7 +36,7 @@ impl Ed25519Signer {
/// [Ed25519Signer] factory
pub fn create_test_signer<R>(mut rng: R) -> Self
where
R: CryptoRng + RngCore,
R: CryptoRng,
{
let secret_key = SigningKey::generate(&mut rng);
Self::from_secret_key(secret_key.into())
Expand All @@ -49,7 +50,7 @@ impl Ed25519Signer {

/// [Ed25519Signer] non deterministic
pub fn create_non_deterministic_signer() -> Self {
let rng = rand_core::OsRng;
let rng = UnwrapErr(SysRng);
Self::create_test_signer(rng)
}

Expand Down
Loading