ci: enforce formatting and hlint via nix flake check - #73
Open
Emmanuel-Tyty wants to merge 1 commit into
Open
Emmanuel-Tyty wants to merge 1 commit into
Emmanuel-Tyty wants to merge 1 commit into
Conversation
haskell.yml only builds/tests with cabal and never ran the pre-commit flake check (nixfmt, ormolu, cabal-fmt) or hlint, contradicting CONTRIBUTING.md's claim that CI enforces formatting. Fixes #72
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+12
to
+24
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - uses: cachix/install-nix-action@v31 | ||
| with: | ||
| extra_nix_config: | | ||
| experimental-features = nix-command flakes | ||
|
|
||
| - name: nix flake check (nixfmt, ormolu, cabal-fmt) | ||
| run: nix flake check --print-build-logs | ||
|
|
||
| hlint: |
Comment on lines
+25
to
+35
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - uses: cachix/install-nix-action@v31 | ||
| with: | ||
| extra_nix_config: | | ||
| experimental-features = nix-command flakes | ||
|
|
||
| - name: Run hlint | ||
| run: nix develop --command hlint . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haskell.yml only builds/tests with cabal and never ran the pre-commit flake check (nixfmt, ormolu, cabal-fmt) or hlint, contradicting CONTRIBUTING.md's claim that CI enforces formatting.
Fixes #72
Pre-submit checklist: