Repository navigation
Phase 2B: Align Notification contracts and Identity review totals - #95
Merged
Merged
Conversation
SaBo4K
marked this pull request as ready for review
November 21, 2026 18:10
qonnow
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReviewPublished, notify company HR once per review onchange: PUBLISHEDand skipchange: REMOVED. Treat legacy events with nochangeasPUBLISHED. E10ADMIN_REMOVEcontinues to notify the student.0/0on removal of the final review. Invalid totals are rejected and olderentity_versionvalues leave the current snapshot intact.Scope
19 files from the approved Phase 2B worktree across Notification (14), Identity (2), documentation (2) and Compose (1). Verified the commit is based on
8277e87and has zero path overlap with the 13 files in #92.Verification
changeand invalidchange.0/0, stale events, legacy events and rejection of impossible totals.git diff --checkpassed.E11 integration pending
ReviewPublishedPayloadincludeschange: 'PUBLISHED' | 'REMOVED'.PUBLISHEDwhen it publishes a review andREMOVEDwhen it removes a published review.review_count: 0andrating_avg: 0.Full E11 end-to-end verification is pending the producer and shared-contract changes. A legacy removal event without
changefollows the backward-compatibility rule and can generate an HR notification before the producer is updated.