Fixed bug in import* and export* functions for chemical and fluid in MEBridgePeripheral throwing java.lang.NullPointerException when remote tank peripherals are specified. - #780
Merged
Conversation
…gePeripheral` not detecting any remote inventory peripherals.
…pheral` not detecting any remote inventory peripherals.
Contributor
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
MineCake147E
marked this pull request as draft
September 1, 2025 12:02
zyxkad
approved these changes
Sep 1, 2025
MineCake147E
marked this pull request as ready for review
September 1, 2025 12:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Unable to import chemical/fluid from any remote inventory peripherals to ME storage
Unable to export chemical/fluid from ME storage to any remote inventory peripherals
What is the new behavior (if this is a feature change)?
Able to import chemical/fluid from any remote inventory peripherals to ME storage
Able to export chemical/fluid from ME storage to any remote inventory peripherals
Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)
No
Other information:
Related to Fix bug in
import*andexport*functions inMEBridgePeripheralnot detecting any remote inventory peripherals. #746FluidUtil.getHandlerFromDirectionandChemicalUtil.getHandlerFromDirectionlacked null checks afterCoordUtil.getDirection(owner.getOrientation(), direction);, which caused import/export functions for chemical and fluid to throwjava.lang.NullPointerException.I should have noticed these bugs before I submitted #746.
I apologize for my mistake.
Log output after running
me_bridge.exportChemical: