Skip to content

test(resources): use a catalogue unit external id in graph_projection_is_one_to_one_and_typed - #168

Merged
olavgg merged 2 commits into
mainfrom
fix/graph-projection-unit-external-id
Sep 30, 2026
Merged

olavgg merged 2 commits into
mainfrom
fix/graph-projection-unit-external-id

Conversation

@JosteinGj

Copy link
Copy Markdown
Contributor

Summary

graph_projection_is_one_to_one_and_typed fails with 400 Unknown unitExternalId 'celsius' against an api that includes platform 9a8b931a ("refuse a blank or unknown unitExternalId"). src/resources/tests.rs:812 set unitExternalId to celsius, which is not in the unit catalogue. It now uses temperature_deg_c, like every other test here. The remaining "celsius" strings in the suite are free-text unit values, which that change does not affect.

No SDK surface changes, so no docs pages are affected.

Test plan

  • cargo test graph_projection_is_one_to_one_and_typed passes locally. My local api predates the validation, so that shows nothing else broke, not that the 400 is gone. The catalogue seeds temperature_deg_c in its migrations.

🤖 Generated with Claude Code

…at exists

The platform now refuses a unitExternalId outside the unit catalogue, and
'celsius' is not in it; every other test uses temperature_deg_c.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: jgjesdal <jostein@intellistream.ai>
@JosteinGj
JosteinGj requested a review from olavgg September 30, 2026 07:29
The api now refuses a unitExternalId outside the unit catalogue, on create
and on update. The filter corpus used 'temperature_c' and the CRUD tests
made ids up ('ext.unit.id', 'orig_unit_ext', 'clear.this.ext',
'updated_unit_ext'); they use temperature_deg_c and pressure_bar now. The
offline constructor tests keep their made-up ids, since they never reach
the api.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: jgjesdal <jostein@intellistream.ai>
@olavgg
olavgg merged commit 17a2197 into main Sep 30, 2026
18 checks passed
@olavgg
olavgg deleted the fix/graph-projection-unit-external-id branch September 30, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants