Repository navigation
fix: binary ingest builds against ResponseError::content_type - #130
Merged
Merged
Conversation
#123 was branched before #128 gave ResponseError a content_type field and merged after it, so main stopped compiling at the three places the binary path builds one. All three are raised by the SDK with no server response behind them (a 204 that fails to deserialize, a value refused locally, a series /byids cannot find), so each carries None. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: jgjesdal <jostein@intellistream.ai>
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoes not compile. #123 (binary datapoint ingest) was branched before #128 gaveResponseErroracontent_typefield and merged after it, so the three places the binary path builds aResponseErrorare missing the field:src/generic.rs— a 204 from/timeseries/data/binarythat fails to deserializesrc/timeseries/binary.rs—unprocessable(), a value refused locallysrc/timeseries/binary.rs— a series/timeseries/byidscould not findAll three are raised by the SDK with no server response behind them, so each carries
None, the same as the JSON path's equivalents.This is only the compile fix. Two follow-ups build on it as separate PRs: the stale-series retry reading the problem document, and the flaky aggregate comparison in
test_datapoints_binary.Verified
cargo build --all-targets --all-featuresand thedatahub_python_bindingscrate build.timeseries::binary,http::tests,problem::tests pass.test_insert_datapoints_binary_missing_timeseries_returns_not_foundpasses.🤖 Generated with Claude Code