Repository navigation
Conversation
The SDK and the platform both used vX.Y.Z tags in this repository, so a platform release would have started the SDK publish. The SDK now tags sdk-vX.Y.Z on release/sdk-vX.Y, mirroring the platform's vX.Y.Z on release/vX.Y. The workflow skips any other release and refuses a tag whose commit is not on its release branch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: jgjesdal <jostein@intellistream.ai>
Contributor
Author
|
Superseded by #152: the platform and the Java SDK are now released together from one vX.Y.Z release, instead of on separate sdk-vX.Y.Z tags. Splitting them later would revive this scheme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Java SDK and the platform live in the same repository, and since #148 both would use
vX.Y.Ztags:release/vX.Y(ci: run checks on release/vX.Y branches #145), with tagsvX.Y.Z. The first is meant to be v1.0.0.vX.Y.Z(build(sdk): make datahub-sdk publishable to Maven Central, with locally signed, CI-verified releases #148).So the day the platform cuts its
v1.0.0release, the SDK workflow starts and tries to publish Java SDK1.0.0. IfjavaSdkVersionisn't1.0.0, the platform release shows a failed check. If it is, the SDK goes to Central whether or not anyone meant to release it, and a Central release is permanent. The two version lines are also unrelated today: the SDK is heading for 0.3.0 while the platform is heading for 1.0.0.This keeps the two separate but alike:
release/vX.YvX.Y.Zrelease/sdk-vX.Ysdk-vX.Y.ZWhat changes
.github/workflows/java-sdk-release.yml:sdk-v, and every other job depends on it. So a platform release shows a skipped run, never a failed one, and can never publish the SDK.sdk-vX.Y.Zand match bothapiModelVersionandjavaSdkVersion, as before.release/sdk-vX.Y. Releases come from the SDK's release branch, the way the platform's come from its own, not from wherever the tag happens to point. This was pushed to build(sdk): make datahub-sdk publishable to Maven Central, with locally signed, CI-verified releases #148's branch after it merged (c3729169) and never reachedmain. It lands here, adapted to the new names.The SDK release branches sit under
release/, so the existingbuild.yml,dco.ymlande2e.ymltriggers (release/**) already run on pull requests into them.e2e.yml's release-line resolver matches onlyrelease/vX.Y, so a pull request intorelease/sdk-vX.Ytests against the Rust SDK'smain, the same as a pull request intomain. That is right, because the Java SDK's release line doesn't follow a platform version.AGENTS.md's release section now describes the two schemes side by side and the SDK steps:# on release/sdk-vX.Y, with both versions set to X.Y.Z ./gradlew centralBundle -PsigningUseGpgCommand=true gh release create sdk-vX.Y.Z --target release/sdk-vX.Y --latest=false build/central/datahub-central-X.Y.Z.zip--latest=falsekeeps the repository's "latest release" badge pointing at the platform.Needed in the GitHub settings
Not code. The
releaseenvironment as configured today:v*, which is the platform's scheme, so ansdk-v*run could not get the Central token. Change it tosdk-v*.Also worth doing: a branch ruleset on
release/*(still open from #145), since "the commit is on the release branch" is only as strong as who can push to it. Add a tag ruleset onsdk-v*andv*restricting who can create them.Docs
Verification
sdk-v0.3.0onrelease/sdk-v0.3passes.sdk-v0.3.0on a commit not on that branch, a platformv0.3.0tag, and an old-stylejava-sdk-v0.3.0tag are all refused.if:skip itself runs only on a real release event, so it is exercised by the first platform or SDK release.🤖 Generated with Claude Code