Skip to content

[NRCL-67] Add versioned cross-runtime contract bundle - #26

Merged
hudsonaikins merged 10 commits into
mainfrom
codex/nrcl-67-contracts
Jul 30, 2026
Merged

[NRCL-67] Add versioned cross-runtime contract bundle#26
hudsonaikins merged 10 commits into
mainfrom
codex/nrcl-67-contracts

Conversation

@hudsonaikins

@hudsonaikins hudsonaikins commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Outcome

Adds Neural's authoritative v1 structural transport contracts for the six Neural-Vaticor MVE objects: JSON Schema, schema-derived Pydantic validation, deterministic fixtures, canonical hashing, exact lineage binding, and signed-envelope verification.

Scope

  • Strict 1.0.0 contracts for MarketSnapshot, ResearchEvidenceRef, ExecutionIntent, RiskDecision, PaperOrder, and PostTradeReview
  • Deterministic canonical JSON, payload hashes, and golden fixtures
  • Exact object identity and payload-hash lineage across the six transport objects
  • Runtime timestamp/URI formats, bounded transport strings and object-ID references, and fail-closed lone-surrogate rejection
  • HMAC envelope validation with non-empty key material, bounded lifetime, expiry, timezone-aware verifier clocks, and injected nonce replay protection
  • Detached public schema copies; packaged schema/fixture/manifest artifacts; Fumadocs architecture documentation
  • Business semantics remain consumer-owned domain validation: market truth, risk approval, order/fill rules, PnL, environment, redaction, and business-time ordering
  • No provider calls, credentials, execution routes, deployment, or package publication

Exact candidate

  • Plane: NRCL-67
  • Base: 5d30d1c0cfe589934853145e498b204e2cf15266
  • Head: a8b4ea8cfc95651687c4a9ffeaec26b276a8f230

Validation

  • Python 3.12 full exact-head suite: 148 passed, 6 skipped
  • Focused structural contract suite: 22 passed
  • Ruff: passed
  • Black: passed
  • mypy neural/contracts: passed
  • generated bundle freshness: passed
  • Hosted CI: pending on current head

Dependency

Vaticor consumes this exact head in its paired NRCL-67 PR. Merge Neural before the Vaticor consumer.

@hudsonaikins
hudsonaikins marked this pull request as ready for review July 30, 2026 02:40
@github-actions

Copy link
Copy Markdown

📚 Documentation Status

✅ Code changes detected

  • Docstring coverage checked
  • API documentation validation completed
    ✅ Documentation changes detected
  • Documentation structure validated
  • Links checked for broken references

This comment is automatically generated by the documentation workflow.

@makeplane

makeplane Bot commented Jul 30, 2026

Copy link
Copy Markdown

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review\n\nRefresh requested for exact head 941c4916397ad5b99f1ae7c4fcdb5516db311b0c after fail-closed verifier-clock fix.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 941c491639

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json
Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json
Comment thread pyproject.toml Outdated
Comment thread neural/contracts/registry.py
Comment thread neural/contracts/canonical.py
Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json
@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f5da7c826

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json
Comment thread neural/contracts/registry.py Outdated
Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json Outdated
Comment thread neural/contracts/registry.py
Comment thread neural/contracts/registry.py
Comment thread neural/contracts/canonical.py
@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6322197a96

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread neural/contracts/registry.py Outdated
Comment thread neural/contracts/registry.py
Comment thread neural/contracts/registry.py Outdated
@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7cd0514ab5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread neural/contracts/registry.py
Comment thread neural/contracts/registry.py
Comment thread neural/contracts/registry.py Outdated
@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7823eed68b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread neural/contracts/registry.py Outdated
Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json
Comment thread neural/contracts/canonical.py
@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebd205a7a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread neural/contracts/registry.py Outdated
Comment thread neural/contracts/schemas/neural-contracts-v1.schema.json
@hudsonaikins

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: a8b4ea8cfc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@hudsonaikins
hudsonaikins merged commit 7c29e5e into main Jul 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant