COMP: Update DCMTK to add printf format attribute in offile.h - #6587
COMP: Update DCMTK to add printf format attribute in offile.h#6587hjmjohnson wants to merge 1 commit into
Conversation
OFFile::fprintf and OFFile::vfprintf forward a non-literal format string to ::vfprintf, warning in every ITK translation unit that includes offile.h. The format attribute silences the false positive and adds format/argument checking at call sites.
8582e46 to
2300b0b
Compare
|
| Filename | Overview |
|---|---|
| Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake | Updates the DCMTK FetchContent commit pin and patch-list comment while keeping the same release-anchored fork branch. |
Reviews (1): Last reviewed commit: "COMP: Update DCMTK to add printf format ..." | Re-trigger Greptile
|
Closing as obsolete — this patch already landed on Why this is superseded (and why rebasing it would regress
|
Updates the vendored DCMTK to add
__attribute__((format(printf, ...)))toOFFile::fprintf/OFFile::vfprintf, fixing two clang-Wformat-nonliteralwarnings emitted in every ITK translation unit that includesoffile.h(e.g. viaitkDCMTKFileReader.h).Details
for/itk-dcmtk-3.7.0-ccfd10b.formatparameter as a valid forwarding target (silencing the wrapper-internal false positive) and enables format/argument checking at all call sites.ITKIODCMTKTestDriverrebuild (all of DCMTK + ITK IODCMTK tests) against the new pin with zero warnings/errors.