Repository navigation
fix(matrix): wrapped runs enter the font subset - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrapped matrix text shipped without its glyphs. The matrix repair on
mainwraps cell text, notes, and headers into runs, but the font-surface collector only read the single-line fields. In the defaultembedmodeΩ b d g i srendered as tofu or fell back to a host font.Separately,
mainis red. Four assertions searched the whole SVG for the digits1200, which timestamps, digests, and font bytes all match. One run spelled them by chance.Changes
_text_surfacecollectstext_lines,sub_lines, and headerlines. Every painted run reaches the subsetter.Ω,ß,Ü,Ø, andμjoins the per-frame cases. A corpus check asserts every rendered codepoint is in the embedded cmap.rendered_textjoins the painted<text>and<tspan>nodes. The stats-card and chart-frame checks read it instead of the raw SVG, which is the red CI fix.Validation
ruff check·ruff format --check·ty checkjust qa