Conversation
📝 WalkthroughWalkthroughReleases Changesinjective-test-tube v1.20.0 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
| serde_json = "1.0.85" | ||
| sha3 = { version = "0.10.8" } | ||
| test-tube-inj = { version = "2.0.10" } | ||
| test-tube-inj = { version = "2.0.11", path = "../test-tube" } |
There was a problem hiding this comment.
why path addition? better to remove
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/injective-test-tube/build.rs`:
- Line 19: The code uses Rust's inline format string syntax (like {variable})
which requires Rust 1.58.0 or later, but the project has no declared MSRV. To
fix this across all four affected locations
(packages/injective-test-tube/build.rs:19,
packages/test-tube/src/runner/app.rs:384,
packages/test-tube/src/runner/result.rs:242, and
packages/injective-test-tube/src/module/auction.rs:104), add rust-version =
"1.58" to the workspace Cargo.toml file. Alternatively, if earlier Rust version
compatibility is required, revert the inline format string syntax at all four
locations back to explicit syntax (e.g., format!("{}", variable) instead of
format!("{variable}")). Choose one approach and apply it consistently across all
affected files to resolve the compatibility gap.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 92ec4d98-1637-4c2e-b5e5-9d330060e8ec
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockpackages/injective-test-tube/libinjectivetesttube/go.sumis excluded by!**/*.sum
📒 Files selected for processing (11)
packages/injective-test-tube/CHANGELOG.mdpackages/injective-test-tube/Cargo.tomlpackages/injective-test-tube/build.rspackages/injective-test-tube/libinjectivetesttube/go.modpackages/injective-test-tube/libinjectivetesttube/testenv/setup.gopackages/injective-test-tube/src/module/auction.rspackages/injective-test-tube/src/module/exchange.rspackages/injective-test-tube/src/module/oracle.rspackages/test-tube/Cargo.tomlpackages/test-tube/src/runner/app.rspackages/test-tube/src/runner/result.rs
| .join("libinjectivetesttube.docrs.h") | ||
| } else { | ||
| out_dir.join(format!("lib{}.h", lib_name)) | ||
| out_dir.join(format!("lib{lib_name}.h")) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for MSRV declarations in project Cargo.toml files
echo "=== Checking for explicit MSRV declarations ==="
fd -t f -name "Cargo.toml" -path "*/packages/*" | xargs grep -H "rust-version" || echo "No explicit rust-version field found"
echo ""
echo "=== Checking for rust-toolchain files ==="
fd -t f -name "rust-toolchain*" || echo "No rust-toolchain files found"
echo ""
echo "=== Checking workspace Cargo.toml ==="
if [ -f "Cargo.toml" ]; then grep -A 5 "\[workspace\]" Cargo.toml | grep -i "rust\|version" || echo "No workspace-level MSRV"; fiRepository: InjectiveLabs/test-tube
Length of output: 768
🏁 Script executed:
#!/bin/bash
# Verify the inline format syntax patterns in all four files
echo "=== File 1: packages/injective-test-tube/build.rs (line 19) ==="
sed -n '15,25p' packages/injective-test-tube/build.rs
echo ""
echo "=== File 2: packages/test-tube/src/runner/app.rs (line 384) ==="
sed -n '380,390p' packages/test-tube/src/runner/app.rs
echo ""
echo "=== File 3: packages/test-tube/src/runner/result.rs (line 242) ==="
sed -n '238,248p' packages/test-tube/src/runner/result.rs
echo ""
echo "=== File 4: packages/injective-test-tube/src/module/auction.rs (line 104) ==="
sed -n '100,110p' packages/injective-test-tube/src/module/auction.rs
echo ""
echo "=== Checking root Cargo.toml for package-level MSRV ==="
head -30 Cargo.toml | grep -E "rust|version"Repository: InjectiveLabs/test-tube
Length of output: 2034
🌐 Web query:
Rust inline format string syntax minimum supported version requirement
💡 Result:
Rust's support for implicit named arguments within format strings (often referred to colloquially as "inline format strings" or f-string-like syntax, such as format!("Hello, {name}")) was stabilized in Rust 1.58.0, released on January 13, 2022 [1][2]. Prior to this version, developers were required to explicitly bind variables if they wanted to use them by name, such as format!("Hello, {name}", name = name). The introduction of this feature allows the macro to implicitly capture local variables with the same name as the identifier provided in the curly braces [3][2]. It is important to note that these are not true "f-strings" in the sense of some other programming languages (which often evaluate arbitrary expressions within the string at runtime). In Rust, the format string must still be a string literal, and the macro operates at compile-time to validate the format string against the provided arguments [4][1]. The feature simply provides syntactic sugar to reduce boilerplate when capturing local variables [3][2]. Subsequent compiler improvements, such as the one implemented in Rust 1.67, further optimized this system by allowing the compiler to flatten or inline literal arguments into the format string during compilation, which can improve performance and help with certain macro-related optimizations [5][6].
Citations:
- 1: https://news.ycombinator.com/item?id=29931884
- 2: https://users.rust-lang.org/t/new-format-syntax-has-rough-edges/88513
- 3: https://rust-lang.github.io/rfcs/2795-format-args-implicit-identifiers.html
- 4: https://doc.rust-lang.org/stable/std/fmt/
- 5: Flatten/inline format_args!() and (string and int) literal arguments into format_args!() rust-lang/rust#106824
- 6: https://github.com/rust-lang/rust/blob/2972b5e5/compiler/rustc_ast_lowering/src/format.rs
Declare project MSRV to match Rust 1.58.0+ requirement for inline format syntax.
All four affected files use Rust's inline format string syntax ({variable} and {variable:?}), which requires Rust 1.58.0 or later. The project currently has no declared MSRV, which creates a compilation compatibility gap. Either add rust-version = "1.58" to the workspace Cargo.toml or revert to explicit format syntax (format!("{}", variable)) for compatibility with earlier Rust versions.
Affected files:
packages/injective-test-tube/build.rs:19packages/test-tube/src/runner/app.rs:384packages/test-tube/src/runner/result.rs:242packages/injective-test-tube/src/module/auction.rs:104
📍 Affects 4 files
packages/injective-test-tube/build.rs#L19-L19(this comment)packages/test-tube/src/runner/app.rs#L384-L384packages/test-tube/src/runner/result.rs#L242-L242packages/injective-test-tube/src/module/auction.rs#L104-L104
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/injective-test-tube/build.rs` at line 19, The code uses Rust's
inline format string syntax (like {variable}) which requires Rust 1.58.0 or
later, but the project has no declared MSRV. To fix this across all four
affected locations (packages/injective-test-tube/build.rs:19,
packages/test-tube/src/runner/app.rs:384,
packages/test-tube/src/runner/result.rs:242, and
packages/injective-test-tube/src/module/auction.rs:104), add rust-version =
"1.58" to the workspace Cargo.toml file. Alternatively, if earlier Rust version
compatibility is required, revert the inline format string syntax at all four
locations back to explicit syntax (e.g., format!("{}", variable) instead of
format!("{variable}")). Choose one approach and apply it consistently across all
affected files to resolve the compatibility gap.
2 participants
Summary by CodeRabbit
Chores
Bug Fixes / Tests
Refactor