fix: use correct precision format for v2 write API - #69
Merged
Merged
Conversation
… - but changes are valid.
karel-rehor
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation correctly addresses the protocol mismatch with comprehensive focused coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes precision formatting for InfluxDB v2 write requests.
Changes:
- Adds v2 short precision strings.
- Selects precision format by write API version.
- Adds unit, mock HTTP, and end-to-end coverage.
| File | Description |
|---|---|
src/precision.rs |
Adds v2 precision formatting and tests. |
src/client.rs |
Uses endpoint-appropriate precision parameters. |
tests/write_tests.rs |
Verifies v2 HTTP query parameters. |
tests/client.rs |
Adds v2 precision end-to-end coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 83.97% 84.12% +0.14%
==========================================
Files 10 10
Lines 2141 2161 +20
==========================================
+ Hits 1798 1818 +20
Misses 343 343 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bug:
Precision::as_str()returns the v3 format (nanosecond,microsecond,millisecond,second), but when the v2 API is selected (use_v2_api = true, targeting/api/v2/write), the server expects the short format (ns,us,ms,s). Previouslysend_lpalways usedas_str()regardless of v2 or v3, so the precision parameter was sent in the wrong format for v2 writes and could be rejected or misinterpreted by the server.Fix:
Precision::as_v2_str()returning the v2 short-format stringssend_lpto select the correct precision format based onuse_v2_api:use_v2_api = true→as_v2_str()(ns/us/ms/s)use_v2_api = false→as_str()(nanosecond/microsecond/millisecond/second)as_v2_str()verifying all four precisions output correctly and round-trip through the v2 formatChecklist
Note
Changes and issue were first submitted in #60, however user Iqleon1214 failed to sign CLA. To speed things up, decided to move these changes to a repository branch.