settings: Add global widget selection

[vkareh]

Instead of each watch face implementing their own settings for which widgets to display, we can have a global selection of widgets. All watch faces can then determine whether it is enabled and so display it in whichever way makes sense for that face.

Current widgets supported are heart rate, step counter, and weather.

Widgets off:

Widgets on:

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	384572B	1792B
data	944B	0B
bss	22640B	8B

Run in InfiniEmu

[FintasticMan]

I think this is very useful, thanks!

[minacode]

I think you could use the CheckboxList class for the settings menu.

You can find it in src/displayapp/screens/CheckboxList.h.

[vkareh]

@minacode the badly-named CheckboxList class only deals with single-selection settings (radio buttons)

[minacode]

Oh, ok. Maybe we should rename it to something like RadioButtonGroup.

Do you think you could still extract an abstract component from your implementation? I could imagine that an actual checkbox list is common enough.

Maybe it doesn't make sense though. That would be ok. I am just asking.

[vkareh]

Oh, ok. Maybe we should rename it to something like RadioButtonGroup.

No, the name is based on the lvgl library, which uses checkbox as the naming. There is no radio component in lvgl, so the checkboxlist class emulates the radio behaviour by re-theming the checkboxes and overriding the select mechanism.

Do you think you could still extract an abstract component from your implementation? I could imagine that an actual checkbox list is common enough.

I did an initial PoC, but it means that now CheckboxList needs to return arrays of settings, whether it's a checkbox or a radio. This and the additional code required to make that work makes the entire thing to complex/bloated.

Maybe it doesn't make sense though. That would be ok. I am just asking.

I can poke at it some more at another time, but likely out of scope for this PR.

[minacode]

Ok, nice. Thanks for the detailed answer. Given that, I think your PR is fine the way it is now :)

[vkareh]

I've added new commits for configurable widgets on the Analog watch face. Attached screenshots to the description on top.

[mark9064]

I think it would be really great if we could get this merged soon, would you be able to fix build (CI is currently failing)? I can review after

[vkareh]

Fixed the build now.

[mark9064]

Looks great! Just a few things:

• In the future there may be some way to modify settings over bluetooth. At the moment changing the enabled widgets could crash a watchface. I think it would be better if the watchfaces store the enabled widgets when they initialise. Maybe as simple as assigning the lvgl object fields to nullptr if they haven't been drawn and then checking if they're not null in Refresh()?
• The settings version needs bumping too

[shaleh]

I have been pondering a refactor of watch faces so there is a core "watch" and the watch faces load this. The face would pass in refresh handlers and init handlers for all of the mini widgets -- weather, steps, bluetooth, battery, etc etc. This would allow for a consistent behavior of the widgets and the faces to decide how and what they render. This PR is a solid step in that direction.