fix: handle Ascend paged flash attention layout - #984
Merged
Merged
Conversation
baominghelly
marked this pull request as ready for review
September 10, 2026 07:44
voltjia
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BnBsNDlayout to the CANN-requiredBnBsHlayout insrc/native/ascend/ops/flash_attn_varlen_func/kernel.h.tests/test_flash_attn_varlen_func.py.Motivation
Ascend paged prefill could produce corrupted output when InfiniLM passed a nontrivial block table. CANN PagedAttention expects the cache layout and length convention used here, while InfiniOps publicly preserves its existing paged tensor contract. No issue is currently linked to this change.
Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
27 passed, 9 skipped; eager ChatGLM3 paged flash-attn inference produced coherent outputFull `pytest` output (optional)
Benchmark / Performance Impact
N/A
Notes for Reviewers
[block_num, block_size, kv_heads, head_dim]; only the ACL descriptor flattens the last two dimensions without copying data./workspace/model-matrix-route-a-20260910/final-pr-smoke-chatglm.logon the Ascend 910C test container.