Repository navigation
Conversation
voltjia
force-pushed
the
feat/ninetoothed-ascend-rmsnorm
branch
from
October 19, 2026 11:42
b4489dc to
c6e2d25
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WITH_NINETOOTHEDto select the Ascend backend in addition to the existing NVIDIA Triton backend.RmsNormimplementation index 9 for Ascend and share its launcher setup with the NVIDIA specialization.triton-adapter-optfor that AOT configuration.Motivation
InfiniOps already integrates NineToothed-generated RMSNorm on NVIDIA. This extends the same generated-native-kernel path to Ascend 910B4 instead of requiring a Python loader at inference time.
Type of Change
feat— new feature / new operator / new platformPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ASCEND)Smoke Test Result
Test Results on Supported Platforms
WITH_CPU=ON,WITH_NVIDIA=ON,WITH_NINETOOTHED=ONbuild passedWITH_CPU=ON,WITH_ASCEND=ON,WITH_NINETOOTHED=ONbuild passedFull `pytest` output
Benchmark / Performance Impact
N/A. This PR adds an Ascend integration path and does not claim a performance result.
Notes for Reviewers
This branch is intended to stack on these upstream changes:
The Ascend validation used NineToothed
9838a1e3, ntopsfcc2ade5, and InfiniRT5175a694on an idle 910B4. The generated launchers embed kernel binaries, register them throughrtDevBinaryRegister/rtFunctionRegister, and invoke them throughrtKernelLaunch.CI Notes
At final head
c6e2d25,clang-format, Ruff, documentation build, matrix generation, and the NVIDIA unit job passed. The repository platform matrix also reported Ascend, Cambricon, and MetaX failures.The latest master run at
5653c00had already failed the same CI workflow in its Ascend and MetaX jobs. The PR Ascend log fails while building stockAscendCworkspace kernels, before NineToothed code generation. The Cambricon errors are native Cambricon embedding/mul type-conversion compile errors and do not reference files changed by this PR. Direct affected-platform builds and tests above pass with the intended upstream dependency stack.