Fixed skill window on character change#160
Open
LuiseEntoinee wants to merge 2 commits into
Open
Conversation
LuiseEntoinee
force-pushed
the
skills_on_character_change
branch
from
3d9af9b to
05bda85
Compare
LuiseEntoinee
force-pushed
the
skills_on_character_change
branch
from
05bda85 to
91e9609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
If your first character has not trained skill X, the skill is not being displayed. Effectively this means that the height of the skill bar is set to 0.
However, if you switch to a character that has trained this skill X: The height is not updated and thus the skill is always displayed with 0% progress.
This PR fixes this issue by getting rid of the 0px height hack and getting rid of outdated layout rows from the previous character.