fix(button-group): fix button group colors in selected state#2219
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the border color used for igc-toggle-button inside igc-button-group when the toggle button is selected + focused (and selected + focused + hover), aligning the border color token with the correct visual state so borders don’t appear as mismatched outlines (notably in Bootstrap, per #2199).
Changes:
- Swaps the border-color tokens for selected “focused” vs selected “focused + hover” states so each state uses its corresponding border token.
- Removes Indigo-specific selected border overrides so the shared/common selected-state border styling can apply consistently across interactions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/button-group/themes/shared/button/button.indigo.scss |
Removes selected-state border overrides for the focused toggle part, relying on shared/common state styling. |
src/components/button-group/themes/shared/button/button.common.scss |
Corrects which selected border token is applied in focused vs focused+hover states to prevent visible border/background mismatch. |
adrianptrv
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2199
test with this theming pr - IgniteUI/igniteui-theming#571
Related Issues
Closes #
Testing
Checklist