Skip to content

feat(combo): update combo overview topics - #1017

Open
Hristo313 wants to merge 12 commits into
vnextfrom
hhristov/update-combo-overview-topics
Open

Hristo313 wants to merge 12 commits into
vnextfrom
hhristov/update-combo-overview-topics

Conversation

@Hristo313

Copy link
Copy Markdown
Contributor

Closes #721

Update the Combo Overview xplat topics

Also updated the samples:
Angular -> IgniteUI/igniteui-angular-samples#4068
React -> IgniteUI/igniteui-react-examples#1138
WC -> IgniteUI/igniteui-wc-examples#1307
Blazor -> IgniteUI/igniteui-blazor-examples#1353

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ./page.mdx or ../relative/path.mdx (.mdx extension required)
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

@DiLazarova

Copy link
Copy Markdown
Contributor

Review for Combo (multi selection )

1. Remove the second Combo Type for all Section
Screenshot 2026-11-12 at 10 33 44

  1. Remove the numeration since we don't have it inside the component. Screenshot 2026-11-12 at 10 40 20

  2. Check the vertical padding in every section

Screenshot 2026-11-12 at 10 50 17

@DiLazarova

Copy link
Copy Markdown
Contributor

In Indigo the Helper text is different color

implementation:
Screenshot 2026-11-12 at 11 15 42

kit:
Screenshot 2026-11-12 at 11 16 33

@DiLazarova

Copy link
Copy Markdown
Contributor

This section should not exist in this form, since the combo component in the “Material” section is the only one with a type; that is, the title and the text below it should apply only to “Material,” and the sample below should be read-only, with no option to change themes.
Screenshot 2026-11-13 at 15 15 29

@DiLazarova

Copy link
Copy Markdown
Contributor

The Hint color in the Bootstrap combo input has Special/Warn/warn.500 color for Warn State;
Screenshot 2026-11-13 at 15 34 37
In Ui Kit:
Screenshot 2026-11-13 at 15 35 29
Please double check all others!

@DiLazarova

Copy link
Copy Markdown
Contributor

Something isn't build right. The components are missing.
Screenshot 2026-11-13 at 15 44 34

@DiLazarova

DiLazarova commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Interaction States

  1. The Fluent Input focused States look broken - light and dark
Screenshot 2026-11-16 at 14 04 46

@DiLazarova

Copy link
Copy Markdown
Contributor

The focused state in Bootstrap is not correct:
Screenshot 2026-11-16 at 14 12 16

The focused state in the UI Kit:
Screenshot 2026-11-16 at 14 13 02
Screenshot 2026-11-16 at 14 13 41

@DiLazarova

Copy link
Copy Markdown
Contributor

The success state in Bootstrap is not correct:
Screenshot 2026-11-16 at 14 16 11
The success state in the UI Kit:
Screenshot 2026-11-16 at 14 16 48

@DiLazarova

Copy link
Copy Markdown
Contributor

This section " Disabled States " should also be read only!
Screenshot 2026-11-16 at 16 23 43

@DiLazarova

Copy link
Copy Markdown
Contributor

The Search Input is not the correct one for Indigo
Screenshot 2026-11-16 at 17 22 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inputs/combo/overview.mdx

2 participants