This repository was archived by the owner on May 19, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
refactor(grids): cleanup search snippets #5851
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,17 +165,17 @@ The methods from above return a **number** value (the number of times the @@igCo | |
|
|
||
| Let's also display the position of the current occurrence, along with the total results count! We can do this by using the grid's `lastSearchInfo` property. This property is automatically updated when using the **find** methods. | ||
|
|
||
| - The `@@igObjectRef.lastSearchInfo.matchInfoCache.length` value will give us the total results count. | ||
| - The `@@igObjectRef.lastSearchInfo.matchCount` value will give us the total results count. | ||
| - The `@@igObjectRef.lastSearchInfo.activeMatchIndex` value will give us the index position of the current occurrence (match). | ||
|
|
||
| ```html | ||
| <!--searchgrid.component.html--> | ||
|
|
||
| <div class="resultsText" *ngIf="@@igObjectRef.lastSearchInfo"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchInfoCache.length }} results | ||
| <div class="resultsText"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchCount }} results | ||
| </span> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length == 0"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount == 0"> | ||
| No results | ||
| </span> | ||
| </div> | ||
|
|
@@ -322,11 +322,11 @@ On the right in our input group, let's create three separate containers with the | |
| <!--searchgrid.component.html--> | ||
|
|
||
| <igx-suffix *ngIf="searchText.length > 0"> | ||
| <div class="resultsText" *ngIf="@@igObjectRef.lastSearchInfo"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchInfoCache.length }} results | ||
| <div class="resultsText"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchCount }} results | ||
| </span> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length == 0"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount == 0"> | ||
| No results | ||
|
Comment on lines
324
to
330
|
||
| </span> | ||
| </div> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,17 +161,17 @@ public exactMatch: boolean = false; | |
|
|
||
| 検索で見つかった現在の場所と総個数を示します。グリッドの `lastSearchInfo` プロパティを使用します。このプロパティは、**find** メソッド使用時に自動的に更新されます。 | ||
|
|
||
| - `@@igObjectRef.lastSearchInfo.matchInfoCache.length` 値は検索で見つかった個数です。 | ||
| - `@@igObjectRef.lastSearchInfo.matchCount` 値は検索で見つかった個数です。 | ||
| - `@@igObjectRef.lastSearchInfo.activeMatchIndex` 値は、現在の一致 (出現) のインデックス位置です。 | ||
|
|
||
| ```html | ||
| <!--searchgrid.component.html--> | ||
|
|
||
| <div class="resultsText" *ngIf="@@igObjectRef.lastSearchInfo"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchInfoCache.length }} results | ||
| <div class="resultsText"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchCount }} results | ||
| </span> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length == 0"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount == 0"> | ||
|
Comment on lines
+170
to
+174
|
||
| No results | ||
| </span> | ||
| </div> | ||
|
|
@@ -317,11 +317,11 @@ public clearSearch() { | |
| <!--searchgrid.component.html--> | ||
|
|
||
| <igx-suffix *ngIf="searchText.length > 0"> | ||
| <div class="resultsText" *ngIf="@@igObjectRef.lastSearchInfo"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchInfoCache.length }} results | ||
| <div class="resultsText"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchCount }} results | ||
| </span> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length == 0"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount == 0"> | ||
| No results | ||
|
Comment on lines
319
to
325
|
||
| </span> | ||
| </div> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,17 +145,17 @@ public exactMatch: boolean = false; | |
| #### 결과 수 표시 | ||
| 총 결과 수와 함께 현재 검색 위치를 표시합니다! 그리드의 `lastSearchInfo` 속성을 사용하여 이것을 실행할 수 있습니다. 이 속성은 **find** 메소드를 사용할 때 자동으로 업데이트됩니다. | ||
|
|
||
| - `@@igObjectRef.lastSearchInfo.matchInfoCache.length` 값은 총 결과 수입니다. | ||
| - `@@igObjectRef.lastSearchInfo.matchCount` 값은 총 결과 수입니다. | ||
| - `@@igObjectRef.lastSearchInfo.activeMatchIndex` 값은 현재 검색(일치)의 인덱스 위치입니다. | ||
|
|
||
| ```html | ||
| <!--searchgrid.component.html--> | ||
|
|
||
| <div class="resultsText" *ngIf="@@igObjectRef.lastSearchInfo"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchInfoCache.length }} results | ||
| <div class="resultsText"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchCount }} results | ||
| </span> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length == 0"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount == 0"> | ||
|
Comment on lines
+154
to
+158
|
||
| No results | ||
| </span> | ||
| </div> | ||
|
|
@@ -294,11 +294,11 @@ public clearSearch() { | |
| <!--searchgrid.component.html--> | ||
|
|
||
| <igx-suffix *ngIf="searchText.length > 0"> | ||
| <div class="resultsText" *ngIf="@@igObjectRef.lastSearchInfo"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchInfoCache.length }} results | ||
| <div class="resultsText"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount > 0"> | ||
| {{ @@igObjectRef.lastSearchInfo.activeMatchIndex + 1 }} of {{ @@igObjectRef.lastSearchInfo.matchCount }} results | ||
| </span> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchInfoCache.length == 0"> | ||
| <span *ngIf="@@igObjectRef.lastSearchInfo.matchCount == 0"> | ||
| No results | ||
|
Comment on lines
296
to
302
|
||
| </span> | ||
| </div> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template now accesses
@@igObjectRef.lastSearchInfo.matchCountwithout guardinglastSearchInfo. IflastSearchInfois undefined before the firstfindNext/findPrevcall, Angular will throw when evaluating the*ngIfexpressions. Consider restoring the*ngIf="@@igObjectRef.lastSearchInfo"guard or using the safe-navigation operator (e.g.,lastSearchInfo?.matchCount).