Skip to content

chore(ai-config): exclude jQuery from presented choices#1692

Merged
damyanpetev merged 1 commit into
masterfrom
dpetev/ai-config-frameworks-arg
May 18, 2026
Merged

chore(ai-config): exclude jQuery from presented choices#1692
damyanpetev merged 1 commit into
masterfrom
dpetev/ai-config-frameworks-arg

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

@damyanpetev damyanpetev commented May 18, 2026

Description

Related Issue

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ai-config command so that jQuery is no longer shown as a selectable framework choice in both the interactive prompt and the --framework help output, aligning the UX with the fact that ai-config isn’t supported for jQuery projects.

Changes:

  • Filtered out jQuery from the interactive framework selection list in ai-config.
  • Filtered out jquery from the --framework option choices (affects help output and validation).
  • Updated the help acceptance spec snapshot to match the new help output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
spec/acceptance/help-spec.ts Updates expected ai-config -h output to remove jquery from framework choices.
packages/cli/lib/commands/ai-config.ts Filters jQuery out of framework choices for prompt + yargs option.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/lib/commands/ai-config.ts
Comment thread packages/cli/lib/commands/ai-config.ts
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 87.371% (+0.003%) from 87.368% — dpetev/ai-config-frameworks-arg into master

@damyanpetev damyanpetev merged commit 0e59bc6 into master May 18, 2026
7 checks passed
@damyanpetev damyanpetev deleted the dpetev/ai-config-frameworks-arg branch May 18, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants