Repository navigation
feat(styles)!: build on ig-design-system and read its semantic tokens - #195
Draft
desig9stein wants to merge 13 commits into
Draft
desig9stein wants to merge 13 commits into
desig9stein wants to merge 13 commits into
Conversation
- DESIGN_SYSTEM_ADOPTION.md records how the styles here compare with ig-design-system: tokens, palette, type, spacing, dark mode and the Ignite UI components in use. - It lists eight gaps to raise in ig-design-system and four questions for the owner. - No component or style is changed.
… a page - A button in the bottom left corner, or ?ds=on in the URL, loads the design system's tokens.css and theme.css after every other stylesheet. - playground/public/design-system holds a copy of the built package; sync-design-system.mjs refreshes it from a sibling checkout. - DESIGN_SYSTEM_ADOPTION.md records what changes when the switch is on and what the trial found. - Nothing under src/ changes.
- The switch sets data-igd-type="docs" on the page, and the copy of the design system is refreshed to a build with base.css split out, no dials and the docs type set. - DESIGN_SYSTEM_ADOPTION.md records the trial again: headings, paragraphs, heading spacing, link underlines and the Ignite UI control size match the page as it is today.
- The trial loads ig-design-system 86e6740, whose default type, spacing, radius and shadow values follow the marketing site. - The docs type set is unchanged, so the playground with the switch on still differs from today only in font family.
…ions - DocsLayout loads the design system (src/styles/design-system, a copy of the built package at 86e6740) before theme.scss and selects its docs type set. - The hand-made palette, the type scale and the Material elevations are removed; the engine variables come from the design system. - Type styles keep their bottom margins, and detail-1 and detail-2 read the design system's body-xs and body-2xs. - The playground trial switch is removed.
- No stylesheet reads a raw gray step: text, surface and border colours are --igd-color-* tokens, with one value per theme and no light-dark() pair. - --igd-accent, --igd-on-accent, --igd-link-color, --igd-link-hover-color, --igd-app-bg, --igd-on-app-bg, --igd-app-outline-color, --igd-font-sans and --igd-padding-sm/md/lg keep their names and point at design system tokens. - Warning callouts read the warning palette, not secondary. - igniteui-theming 30.2 is accepted beside 29; the compiled playground CSS is the same with both. - README, llms.txt and AGENTS.md describe the design system and the semantic colour rule.
- The success palette is built from green #028a54, so the Do frame and the copied state stay green.
- The Do accent reads success-600 (light) and success-200 (dark); the Don't accent reads error-500 (light) and error-300 (dark). - The design system's ramps run darker at the high steps, so success-900 was near-black and error-700 maroon. - Label contrast: 7.35:1 and 5.41:1 on the light page, 8.25:1 and 6.07:1 on the dark page.
…steps moved - Warning callouts are amber in both themes: text reads warn-500 and warn-600 on warn-50 (4.57:1 and 6.19:1), and warn-200 and warn-100 on warn-800 in the dark theme. - The dark info callout title reads primary-300 (5.56:1); it was 4:1. - The note callout's code chip reads color-surface-subtle; its light value named a variable that does not exist and its dark value was a secondary step. - The copied tick on a code block reads success-400. - Sample and icon gallery backgrounds read color-surface-page and color-surface-card.
- New, Updated, Preview and Premium read the design system's badge tokens; Open source reads neutral text, surface and border tokens. - 15 typed-in light and dark colour pairs are removed. - The design system copy is e240e7d.
- No stylesheet reads a raw palette step. Callouts, Do and Don't, the icon gallery, links, chips and the copy tick read feedback, action, tint and accent tokens. - DocsLayout loads the design system's optional fonts.css; the font rules left tokens.css. - light-dark() is left in 5 places that are not palette colours: the logo type, two shadows, a shimmer and a transparent sample background. - The design system copy is 17e4b6f.
…tem tokens - 131 padding, margin and gap values on the spacing scale read space-inset, space-stack and space-gap tokens, with no change in size. - The 26px block rhythm reads space-stack-xl, so it is 24px. - The 4px corner radius reads radius-xs, so it is 6px; 8px reads radius-sm. - Widths, heights, offsets and 18 values off the scale stay as typed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package builds on the Infragistics design system:
DocsLayoutloads it as the base, and every component reads its tokens. One system then serves the docs, the API docs, the blog and the marketing site.DocsLayoutloadssrc/styles/design-system/(fonts.css,tokens.css,theme.css) beforetheme.scssand setsdata-igd-type="docs"on<html>. The folder is a copy of the builtig-design-systempackage at17e4b6f;node scripts/sync-design-system.mjsrefreshes it._palette.scss, 485 lines), the type scale (_type-scale.scss) and the Material elevations are removed. The engine variables (--ig-primary-500,--ig-h1-font-size,--ig-elevation-4) come from the design system. Type styles keep their bottom margins in_type.scss.--igd-color-*tokens; callouts, Do and Don't, the icon gallery and the copy tick read feedback tokens; the status badges read badge tokens.light-dark()calls go from 158 to 5, none of them a palette colour.--igd-space-*and--igd-radius-*tokens. Widths, heights and offsets stay as typed: they are not part of the design system.--igd-accent,--igd-on-accent,--igd-link-color,--igd-link-hover-color,--igd-app-bg,--igd-on-app-bg,--igd-app-outline-color,--igd-font-sans,--igd-padding-sm/md/lgand the status badge names keep their names and point at design system tokens.This is a draft. The design system is not published yet, so it is a copied folder and not a dependency.
Related issue
No issue
Type of change
How to test
npm run playground, open http://localhost:4567.npm run format:check,npm test,npm run lint,npm run playground:check,npm run playground:build.Results: 221 tests pass; lint, playground check (0 errors) and playground build (33 pages) pass;
format:checkpasses for tracked files.Measured in Chromium on 16 playground pages in the light theme, every element's computed font, size, weight, box size, radius, padding and colours, against
master:#101828becomes#16181b). The accent stays#155dfc. Borders that used gray 300 are one step lighter; borders that used gray 400 are darker and meet 3:1.#06633c, 7.35:1) and Don't is red (#cf1b3e, 5.41:1). Warning callouts are amber; they were orange, the old secondary colour.igniteui-theming29.0.0 and 30.2.0.The dark theme was not reviewed. Nobody is working on it and the sites have no switch for it yet.
Consumer impact
--igd-font-bodyor--igd-font-displayitself.--ig-secondary-*.--ig-primary-600was the accent#155dfcand is now#2462ea; the accent is--igd-accent. The high steps run darker:--ig-success-900was a green and is near-black.$igd-type-scaleis no longer forwarded fromstyles/global, and$light-palette/$dark-paletteare gone.--igd-font-monois the design system's stack ('JetBrains Mono', ui-monospace, monospace).igniteui-themingaccepts^29.0.0 || ^30.2.0. The dev dependency moves to 30.2.Notes for the reviewer
src/styles/design-system/is generated output from another repository and is in.prettierignore. Do not review it line by line.GlobalNavBarstill namesaktiv-grotesk, so the Typekit link stays.color-surface-inverseandcolor-text-inverse; the tree item hover background usescolor-surface-muted; the "Open source" badge is neutral gray so it differs from the green "New"; "Preview" is amber because the palette has no orange.DESIGN_SYSTEM_ADOPTION.mdis a working report with the inventory. Remove it before merge.