fix(Pivot): Fix pivot selector error when initializing. Fix adding row dimension with API - #17593
Merged
Merged
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new IgxPivotDataSelectorComponent grid @Input setter can throw at runtime when Angular sets the input to undefined/null during initialization or teardown.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses pivot-grid regressions introduced by removing zone.js, focusing on ensuring pivot selector initialization doesn’t throw change-detection errors and that row-dimension insertion via the public API updates immediately.
Changes:
- Emit
pivotConfigurationChangewhen the pivot configuration is set during initialization to notify external listeners like the pivot selector. - Trigger change detection after inserting non-filter dimensions via
insertDimensionAtto ensure the grid updates without relying on incidental CD triggers. - Update the pivot data selector to retrigger its filtering pipe on configuration changes and add unit coverage for both the core grid and Angular Elements scenarios.
File summaries
| File | Description |
|---|---|
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts | Emits config-change on initial config set; schedules CD after dimension insertion. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-data-selector.component.ts | Subscribes to pivotConfigurationChange and retriggers selector filtering + marks for check. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-data-selector.component.html | Switches filter pipe trigger input from grid?.pipeTrigger to local pipeRetrigger. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts | Adds unit test for inserting a row dimension into a freshly assigned config. |
| projects/igniteui-angular-elements/src/app/custom-strategy.spec.ts | Adds Elements test to validate pivot grid + pivot selector initialization. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MayaKirova
approved these changes
Sep 10, 2026
skrustev
added
✅ status: verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17590 #17591
Description
Fix pivot selector initialization.
Fix row adding through the insertDimensionAt public API
Motivation / Context
Those issues are regressed with the removal of the zone.js from the repo.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)