fix(Pivot): Fix pivot selector error when initializing. Fix adding row dimension with API - #17592
Open
mddragnev wants to merge 6 commits into
Open
fix(Pivot): Fix pivot selector error when initializing. Fix adding row dimension with API#17592mddragnev wants to merge 6 commits into
mddragnev wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Pivot Data Selector grid input setter can throw at runtime when grid is temporarily undefined/null due to unguarded subscription setup.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes Pivot Grid + Pivot Selector regressions in zoneless/Angular Elements scenarios by ensuring configuration changes trigger the right re-rendering paths and by adding targeted regression tests.
Changes:
- Emit
pivotConfigurationChangewhen the entirepivotConfigurationinput is replaced, and ensure CD is scheduled after non-filter dimension inserts. - Update Pivot Data Selector to retrigger its filtering pipe when the grid’s pivot configuration changes (subscription +
markForCheck). - Add unit/regression tests for row dimension insertion via
insertDimensionAtand for Elements initialization with a pivot selector.
File summaries
| File | Description |
|---|---|
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts | Emits config-change on full config replacement; schedules CD after non-filter inserts to address zoneless update gaps. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-data-selector.component.ts | Subscribes to grid config changes and retriggers selector filtering + marks for check. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-data-selector.component.html | Switches pipe trigger input from grid?.pipeTrigger to a selector-owned retrigger counter. |
| projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts | Adds regression test for inserting a row dimension and verifying rendered headers. |
| projects/igniteui-angular-elements/src/app/custom-strategy.spec.ts | Adds Elements regression test ensuring pivot grid + selector initialize without ExpressionChangedAfterItHasBeenCheckedError. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MayaKirova
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17590 #17591
Description
Fix pivot selector initialization.
Fix row adding through the
insertDimensionAtpublic APIMotivation / Context
Those issues are regressed with the removal of the
zone.jsfrom the repo.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)