Skip to content

fix(Pivot): Fix pivot selector error when initializing. Fix adding row dimension with API - #17592

Open
mddragnev wants to merge 6 commits into
masterfrom
mdragnev/fix-pivot
Open

fix(Pivot): Fix pivot selector error when initializing. Fix adding row dimension with API#17592
mddragnev wants to merge 6 commits into
masterfrom
mdragnev/fix-pivot

Conversation

@mddragnev

@mddragnev mddragnev commented Sep 10, 2026

Copy link
Copy Markdown
Member

Closes #17590 #17591

Description

Fix pivot selector initialization.
Fix row adding through the insertDimensionAt public API

Motivation / Context

Those issues are regressed with the removal of the zone.js from the repo.

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

@mddragnev
mddragnev marked this pull request as ready for review September 10, 2026 12:40
Copilot AI lite review requested due to automatic review settings September 10, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Pivot Data Selector grid input setter can throw at runtime when grid is temporarily undefined/null due to unguarded subscription setup.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Fixes Pivot Grid + Pivot Selector regressions in zoneless/Angular Elements scenarios by ensuring configuration changes trigger the right re-rendering paths and by adding targeted regression tests.

Changes:

  • Emit pivotConfigurationChange when the entire pivotConfiguration input is replaced, and ensure CD is scheduled after non-filter dimension inserts.
  • Update Pivot Data Selector to retrigger its filtering pipe when the grid’s pivot configuration changes (subscription + markForCheck).
  • Add unit/regression tests for row dimension insertion via insertDimensionAt and for Elements initialization with a pivot selector.
File summaries
File Description
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts Emits config-change on full config replacement; schedules CD after non-filter inserts to address zoneless update gaps.
projects/igniteui-angular/grids/pivot-grid/src/pivot-data-selector.component.ts Subscribes to grid config changes and retriggers selector filtering + marks for check.
projects/igniteui-angular/grids/pivot-grid/src/pivot-data-selector.component.html Switches pipe trigger input from grid?.pipeTrigger to a selector-owned retrigger counter.
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts Adds regression test for inserting a row dimension and verifying rendered headers.
projects/igniteui-angular-elements/src/app/custom-strategy.spec.ts Adds Elements regression test ensuring pivot grid + selector initialize without ExpressionChangedAfterItHasBeenCheckedError.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts Outdated
@skrustev skrustev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💠 grid: elements grid: pivot version: 22.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

4 participants