Skip to content

fix(progress-circular): update to use track-color instead of base-circle-color for inner stroke#17182

Merged
simeonoff merged 6 commits into
masterfrom
mpopov/circular-progress-bar/change-css-token
Apr 16, 2026
Merged

fix(progress-circular): update to use track-color instead of base-circle-color for inner stroke#17182
simeonoff merged 6 commits into
masterfrom
mpopov/circular-progress-bar/change-css-token

Conversation

@desig9stein
Copy link
Copy Markdown
Contributor

@desig9stein desig9stein commented Apr 15, 2026

Related IgniteUI/igniteui-theming#536
To test, you need to install the theming package from IgniteUI/igniteui-theming#565

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein requested a review from simeonoff April 15, 2026 08:54
Copilot AI review requested due to automatic review settings April 15, 2026 08:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the circular progress theme styling to align with the shared progress track token coming from the theming schema, so the inner circle stroke uses the correct “track” color.

Changes:

  • Switch circular progress inner stroke from base-circle-color to track-color.

@IvanKitanov17 IvanKitanov17 added the ✅ status: verified Applies to PRs that have passed manual verification label Apr 15, 2026
@simeonoff simeonoff merged commit b1eb339 into master Apr 16, 2026
6 checks passed
@simeonoff simeonoff deleted the mpopov/circular-progress-bar/change-css-token branch April 16, 2026 12:33
Comment on lines +283 to +286
"migration-55": {
"version": "21.2.0",
"description": "Updates Ignite UI for Angular from v21.1.x to v21.2.0",
"factory": "./update-21_2_0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desig9stein Um this is very much missing ATM. I see the first commit add the correct files for the migration with the wrong name and then the name correction removes the rest of the files.

Did you forget to commit the renamed added versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

‼️ breaking-change ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants