tests(progressBar): Fix tests for Circular and Linear Bars not clearing test bed.#15887
Closed
skrustev wants to merge 1 commit into
Closed
tests(progressBar): Fix tests for Circular and Linear Bars not clearing test bed.#15887skrustev wants to merge 1 commit into
skrustev wants to merge 1 commit into
Conversation
skrustev
changed the title
damyanpetev
reviewed
Jun 4, 2025
Comment on lines
+30
to
+33
| // Remove elements manually from DOM, because CircularBar overrides the id the TestBed uses | ||
| fixture.elementRef.nativeElement.remove(); | ||
| fixture.destroy(); | ||
| }); |
Member
There was a problem hiding this comment.
This is few lines above in the beforeEach for the exact same reason:
// For test fixture destroy
progress.id = "root1";Did that stop working? Because it's used in other component's tests too.
Member
There was a problem hiding this comment.
Oh, that's a follow up to the PR adding it. Should it be removed? Did it never work?
Contributor
There was a problem hiding this comment.
@skrustev @damyanpetev same question as in #15663. Should we close them?
Member
Author
There was a problem hiding this comment.
Hmm I guess it has been added after I committed the changes. It appears to be working, apparently by setting id with name root in it. Will close this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15616
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)