Repository navigation
refactor!: rename IgbColumnConfiguration, align GetColumns, Sort, NavigateTo - #72
Merged
Merged
Conversation
…d SortAsync signatures
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The API, serializer context, tests, demo, and changelog are consistently updated.
0 open findings
What changed in this PR
Standardizes three public APIs before stabilization and documents the breaking changes.
Changes:
- Renames the column configuration model.
- Aligns
GetColumnsAsyncwith otherTask-returning APIs. - Corrects the singular
SortAsyncparameter name and updates consumers/tests.
| File | Description |
|---|---|
CHANGELOG.md |
Documents all breaking API changes. |
src/IgniteUI.Blazor.GridLite/IgbGridLite.razor.cs |
Updates method signatures and serialization metadata usage. |
src/IgniteUI.Blazor.GridLite/Internal/GridLiteJsonContext.cs |
Registers the renamed model. |
src/IgniteUI.Blazor.GridLite/Models/IgbGridLiteColumnConfiguration.cs |
Renames the public configuration type. |
tests/IgniteUI.Blazor.GridLite.Tests/GridLiteJsInteropTests.cs |
Updates interop coverage for the new API. |
tests/IgniteUI.Blazor.GridLite.Tests/ModelSerializationTests.cs |
Updates serialization coverage. |
demo/GridLite.DemoApp/Components/Pages/Home.razor |
Migrates demo usages to the renamed type. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
MayaKirova
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small public API fixes. Each one is a breaking change after 1.0, so they go in now.
IgbColumnConfigurationIgbGridLiteColumnConfigurationGetColumnsAsync()ValueTask<IgbColumnConfiguration[]>Task<IgbGridLiteColumnConfiguration[]>SortAsync(IgbGridLiteSortingExpression …)expressionsexpressionNavigateToAsync(row, …)long rowint rowGridLitein its name, in theIgniteUI.Blazor.Controlsnamespace thatIgniteUI.BlazorandIgniteUI.Blazor.Liteshare. Nothing collides today, but the generic name was the most likely to.Taskinstead ofValueTask: every other method of the grid returnsTask.ValueTaskonly pays off for a call that often completes synchronously and runs often enough for aTaskallocation to matter (ValueTask<TResult>remarks).GetColumnsAsyncis neither: it is a JS interop round trip.Taskalso spares callersValueTask's restrictions: await only once, andAsTask()beforeTask.WhenAll.FilterAsync's. Only calls that name the argument are affected.introw index: row indices areintin .NET's collections (IList<T>[int]) and most other similar uses.longadds nothing here: a JavaScript array holds at most 2^32 − 1 elements, and integers above 2^53 − 1 aren't exact on the client anyway. Calls passing anintor a literal are unaffected; alongneeds a cast.