Skip to content

refactor!: rename IgbColumnConfiguration, align GetColumns, Sort, NavigateTo - #72

Merged
damyanpetev merged 2 commits into
dpetev/filter-conditionfrom
dpetev/naming-updates
Oct 8, 2026
Merged

damyanpetev merged 2 commits into
dpetev/filter-conditionfrom
dpetev/naming-updates

Conversation

@damyanpetev

@damyanpetev damyanpetev commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Four small public API fixes. Each one is a breaking change after 1.0, so they go in now.

Member Before After
Column configuration type IgbColumnConfiguration IgbGridLiteColumnConfiguration
GetColumnsAsync() ValueTask<IgbColumnConfiguration[]> Task<IgbGridLiteColumnConfiguration[]>
SortAsync(IgbGridLiteSortingExpression …) parameter expressions parameter expression
NavigateToAsync(row, …) long row int row
  • The rename: it was the only public type without GridLite in its name, in the IgniteUI.Blazor.Controls namespace that IgniteUI.Blazor and IgniteUI.Blazor.Lite share. Nothing collides today, but the generic name was the most likely to.
  • Task instead of ValueTask: every other method of the grid returns Task. ValueTask only pays off for a call that often completes synchronously and runs often enough for a Task allocation to matter (ValueTask<TResult> remarks). GetColumnsAsync is neither: it is a JS interop round trip. Task also spares callers ValueTask's restrictions: await only once, and AsTask() before Task.WhenAll.
  • The parameter name: the single-expression overload takes one expression, like FilterAsync's. Only calls that name the argument are affected.
  • int row index: row indices are int in .NET's collections (IList<T>[int]) and most other similar uses. long adds nothing here: a JavaScript array holds at most 2^32 − 1 elements, and integers above 2^53 − 1 aren't exact on the client anyway. Calls passing an int or a literal are unaffected; a long needs a cast.

@damyanpetev
damyanpetev requested a balanced review from Copilot October 8, 2026 09:18
@damyanpetev
damyanpetev added this pull request to stack #73 October 8, 2026 09:18
@damyanpetev damyanpetev changed the title refactor!: rename IgbColumnConfiguration and align GetColumnsAsync an… refactor!: rename IgbColumnConfiguration, align GetColumns & SortAsync Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The API, serializer context, tests, demo, and changelog are consistently updated.

0 open findings

What changed in this PR

Standardizes three public APIs before stabilization and documents the breaking changes.

Changes:

  • Renames the column configuration model.
  • Aligns GetColumnsAsync with other Task-returning APIs.
  • Corrects the singular SortAsync parameter name and updates consumers/tests.
File Description
CHANGELOG.md Documents all breaking API changes.
src/​IgniteUI.Blazor.GridLite/​IgbGridLite.razor.cs Updates method signatures and serialization metadata usage.
src/​IgniteUI.Blazor.GridLite/​Internal/​GridLiteJsonContext.cs Registers the renamed model.
src/​IgniteUI.Blazor.GridLite/​Models/​IgbGridLiteColumnConfiguration.cs Renames the public configuration type.
tests/​IgniteUI.Blazor.GridLite.Tests/​GridLiteJsInteropTests.cs Updates interop coverage for the new API.
tests/​IgniteUI.Blazor.GridLite.Tests/​ModelSerializationTests.cs Updates serialization coverage.
demo/​GridLite.DemoApp/​Components/​Pages/​Home.razor Migrates demo usages to the renamed type.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@damyanpetev
damyanpetev requested a review from MayaKirova October 8, 2026 11:01
@damyanpetev damyanpetev changed the title refactor!: rename IgbColumnConfiguration, align GetColumns & SortAsync refactor!: rename IgbColumnConfiguration, align GetColumns, Sort, NavigateTo Oct 8, 2026
@damyanpetev
damyanpetev merged commit f3b4409 into master Oct 8, 2026
6 checks passed
@damyanpetev
damyanpetev deleted the dpetev/naming-updates branch October 8, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants