Repository navigation
Conversation
CI runs check with -PrequireContainerTests=true, so a test task that skips any test fails. Runs without Docker are not stored in the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
@Testcontainers(disabledWithoutDocker = true), andVirtualFillPersistenceTestassumes Docker. Without Docker,./gradlew checkpassed with 218 of 745 tests skipped, so CI could pass without running a single PostgreSQL or Redis test.-PrequireContainerTests=true, eachTesttask reads its JUnit XML after the run and fails if any test was skipped, naming each skipped class. The CIcheckstep now passes it. Local runs without the property behave as before.DOCKER_HOST,~/.testcontainers.properties, then the default sockets). It is a test input, and a test task that ran without Docker is never stored in the build cache, so a later run with Docker executes the tests instead of reusing a skip-only result.DEVELOPMENT.mddocuments both.Verified
DOCKER_HOST=unix:///nonexistent/docker.sock ./gradlew check -PrequireContainerTests=true --no-daemon --no-build-cache: BUILD FAILED. Thetrading-persistence,market-gateway,market-data-adapterandtrading-workertest tasks failed and listed their skipped classes, includingVirtualFillPersistenceTest.DOCKER_HOSTwithout the property: BUILD SUCCESSFUL, 745 tests with 218 skipped. With--build-cache --info, every test task logs'Docker is available, so container tests ran' not satisfiedas the reason caching is disabled../gradlew check -PrequireContainerTests=true --no-daemon --no-build-cache: BUILD SUCCESSFUL, with 745 tests and 0 skipped, failed or errored. The configuration cache entry was stored.:modules:market-data-adapter:testbecause inputdockerAvailablechanged.pwsh ./scripts/test-github-action-pins.ps1: passed.Checklist
Related: #159 (Testcontainers 2.0.5 alignment)