Modernize modal js#5502
Open
nilmerg wants to merge 3 commits intofeature/prevent-unintentional-closing-of-a-modal-5307from
Open
Modernize modal js#5502nilmerg wants to merge 3 commits intofeature/prevent-unintentional-closing-of-a-modal-5307from
nilmerg wants to merge 3 commits intofeature/prevent-unintentional-closing-of-a-modal-5307from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the modal dialog behavior implementation by migrating it to ES6 class syntax and replacing some jQuery usage with native DOM APIs / notjQuery helpers.
Changes:
- Refactor
Modalbehavior from prototype-based functions to an ES6classextendingIcinga.EventListener - Replace several jQuery element interactions with native DOM methods (e.g.,
getElementById,querySelector,classList) - Update modal lifecycle handling (creation, focus, wobble animation, removal) to use internal state (
this._modal) and less jQuery
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nilmerg
force-pushed
the
feature/prevent-unintentional-closing-of-a-modal-5307
branch
from
faaa549 to
256caeb
Compare
nilmerg
force-pushed
the
modernize-modal-js
branch
from
327b545 to
98ee1a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires
trigger()ipl-web#379