Minor fixes and tests for BinaryToHex()#10841
Open
julianbrost wants to merge 3 commits into
Open
Conversation
…NGTH Forgot to replace one of the two uses of SHA_DIGEST_LENGTH with length in 6cd3a48. All users use it for SHA1 so far, so there was no wrong usage yet.
int is just not the right type to use for an index variable, so change it to size_t, even if it's unlikely to be called on sufficently large inputs that it would actually make a difference.
julianbrost
added
core/quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the
BinaryToHex()function that didn't have real-world impact (yet), as it was only used for SHA1 hashes so far:lengthparameter in one place.intto iterate over the input, instead ofsize_t(which is already used for thelengthparameter).While at it, I've also added some tests for the function.
fixes #10840