Handle rule filter serialization#469
Open
BastianLedererIcinga wants to merge 4 commits into
Open
Conversation
BastianLedererIcinga
force-pushed
the
rule-filter-handling
branch
2 times, most recently
from
e3da66a to
b8a38fc
Compare
BastianLedererIcinga
force-pushed
the
rule-filter-handling
branch
7 times, most recently
from
222ee6b to
d5fe2f5
Compare
`RuleSerializer` serializes rules as json `RuleParser` can read them and create an ipl `Filter\Ŗule` from it
Introduce a new version of the `SourceHook` interface for v 1.0
Use the functions of the new `SourceHook` interface, the `RuleParser` and `RuleSerializer` to set up the filter editor of an event rule-
BastianLedererIcinga
force-pushed
the
rule-filter-handling
branch
from
d5fe2f5 to
3bf7acb
Compare
nilmerg
reviewed
May 12, 2026
Comment on lines
+89
to
+92
| $condition instanceof Filter\Unlike => '!~', | ||
| $condition instanceof Filter\Unequal => '!=', | ||
| $condition instanceof Filter\Like => '~', | ||
| $condition instanceof Filter\Equal => '=', |
Member
There was a problem hiding this comment.
I noticed that Icinga Notifications will interpret the like/unlike expressions as regex internally. My suggestion there is to remove the distinction between like/equal and unlike/unequal, as this was only the case in Web because our query string representation needed a way to express this to avoid the need to distinguish such based on whether an asterisk (*) is contained in the value or not. Now that we don't rely on this anymore here, let's just pre-process the value of a like/unlike as regex and serialize it as regex instead of value and use the non-like operator counterpart instead.
Pre-process in this case means, foo* will be prepared as ^foo.*$.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #466
Introduce
RuleSerializerto create Json from a configured filter.Introduce
Icinga\Module\Notifications\Hook\V2which no longer requiresserializeRuleFilter()andgetRuleFilterTargets()as they are now obsolete.Adjust
EventRuleControllerto skip target selection use the newRuleSerializer.require Icinga/ipl-web#376