Skip to content

Modernize the code#403

Open
jrauh01 wants to merge 26 commits into
mainfrom
use-typed-class-attributes
Open

Modernize the code#403
jrauh01 wants to merge 26 commits into
mainfrom
use-typed-class-attributes

Conversation

@jrauh01
Copy link
Copy Markdown
Contributor

@jrauh01 jrauh01 commented Nov 13, 2025 •
edited
Loading

As we now use php 8.2 as minimal version, the following modernizations have been added to the code:

  • Typed class properties
  • Return values for methods
  • Match expressions
  • Modern string functions (e.g. str_contains(), str_starts_with() and str_ends_with())
  • Nullsafe operator usage
  • Deprecated code has been replaced
  • Imports are now used everywhere

Additionally the import blocks have been sorted, indentation has been fixed, and some smaller adjustments.

resolve #378
require Icinga/ipl-web/pull/342

@jrauh01 jrauh01 self-assigned this Nov 13, 2025
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Nov 13, 2025
@jrauh01 jrauh01 added the enhancement New feature or improvement label Nov 13, 2025
@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch 3 times, most recently from 2bf4959 to 25c7cb4 Compare November 14, 2025 09:29
@jrauh01 jrauh01 requested a review from nilmerg November 14, 2025 09:34
@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch 3 times, most recently from 34029a8 to 3af0375 Compare November 18, 2025 08:16
sukhwinder33445
sukhwinder33445 requested changes Nov 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked through the files up to MoveRotationForm.php.

Comment thread application/controllers/ContactsController.php
Comment thread application/controllers/ContactGroupController.php Outdated
Comment thread application/controllers/ContactGroupController.php Outdated
Comment thread application/controllers/EventRuleController.php Outdated
Comment thread application/controllers/EventRuleController.php Outdated
Comment thread application/controllers/IncidentController.php Outdated
Comment thread application/forms/DatabaseConfigForm.php Outdated
Comment thread application/forms/EventRuleConfigElements/DynamicElements.php Outdated
sukhwinder33445
sukhwinder33445 reviewed Nov 20, 2025
View reviewed changes
Comment thread application/forms/RotationConfigForm.php Outdated
Comment thread application/forms/RotationConfigForm.php Outdated
Comment thread application/forms/RotationConfigForm.php Outdated
Comment thread application/forms/RotationConfigForm.php Outdated
@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch from 3af0375 to 3723f76 Compare November 24, 2025 14:52
@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch 2 times, most recently from 0094a30 to c043776 Compare November 25, 2025 13:09
sukhwinder33445
sukhwinder33445 requested changes Nov 25, 2025
View reviewed changes
Comment thread application/controllers/ChannelsController.php Outdated
Comment thread application/forms/ChannelForm.php Outdated
Comment thread application/forms/ChannelForm.php Outdated
Comment thread application/forms/MoveRotationForm.php Outdated
Comment thread application/forms/RotationConfigForm.php
Comment thread library/Notifications/Web/Control/SearchBar/ExtraTagSuggestions.php Outdated
Comment thread library/Notifications/Web/Control/SearchBar/ObjectSuggestions.php
Comment thread library/Notifications/Widget/Calendar/Entry.php Outdated
Comment thread library/Notifications/Widget/TimeGrid/ExtraEntryCount.php Outdated
Comment thread library/Notifications/Model/RuleEscalationRecipient.php
@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch 3 times, most recently from 1fa2990 to 5820718 Compare November 26, 2025 10:10
sukhwinder33445
sukhwinder33445 previously approved these changes Nov 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch from 5820718 to 3cfc457 Compare November 27, 2025 06:07
@jrauh01
Copy link
Copy Markdown
Contributor Author

jrauh01 commented Nov 27, 2025 •
edited
Loading

The last force push did not change anything, but only moved a change from one commit into another.

nilmerg
nilmerg previously requested changes Nov 28, 2025
View reviewed changes
Comment thread application/forms/RotationConfigForm.php Outdated
Comment thread library/Notifications/Api/OpenApiDescriptionElement/Response/SuccessDataResponse.php
Comment thread library/Notifications/Widget/Detail/ObjectHeader.php Outdated
@nilmerg nilmerg removed the enhancement New feature or improvement label Nov 28, 2025
@jrauh01 jrauh01 force-pushed the use-typed-class-attributes branch from 3cfc457 to 33260df Compare December 1, 2025 06:36
@jrauh01 jrauh01 requested a review from nilmerg December 1, 2025 07:18
@sukhwinder33445 sukhwinder33445 mentioned this pull request Dec 5, 2025
Merged
jrauh01 and others added 26 commits April 29, 2026 09:02
@jrauh01 @BastianLedererIcinga
Use typed class properties
ab05837
@jrauh01 @BastianLedererIcinga
Use typed method return values
5ff39dc
@jrauh01 @BastianLedererIcinga
Sort imports
2f65f6e
@jrauh01 @BastianLedererIcinga
Document thrown exceptions
61a4ed5
@jrauh01 @BastianLedererIcinga
Use match expressions
0ee3728
@jrauh01 @BastianLedererIcinga
Use modern string functions
8decd25
@jrauh01 @BastianLedererIcinga
Replace deprecated code
6d3ff7f
@jrauh01 @BastianLedererIcinga
Explicitly create Attributes
c8a13a7
@jrauh01 @BastianLedererIcinga
Add inline type docs
acd7438
@jrauh01 @BastianLedererIcinga
Use imports
a109e9a
@jrauh01 @BastianLedererIcinga
Fix typos
6d3b2e5
@jrauh01 @BastianLedererIcinga
Adjust method docs
0d39d08
@jrauh01 @BastianLedererIcinga
Add method param types
7b6570b
@jrauh01 @BastianLedererIcinga
Use nullsafe operator
d314873
@jrauh01 @BastianLedererIcinga
Fix indentations and spaces
466038e
@jrauh01 @BastianLedererIcinga
Fix invalid key for select input
d8a04d9
@jrauh01 @BastianLedererIcinga
Remove superfluous $filter property
cca8647
@jrauh01 @BastianLedererIcinga
Remove properties that use parent value as default
ac4294c
@jrauh01 @BastianLedererIcinga
Fix typo in PHPDoc
985660a
@jrauh01 @BastianLedererIcinga
Remove redundant @var annotations from typed properties
fa30a1e
@jrauh01 @BastianLedererIcinga
Use static return value where appropriate
93d554f
@jrauh01 @BastianLedererIcinga
Narrow types where possible
c07c0c6
@BastianLedererIcinga
IdTagAggregator: Remove unnecessary param annotations
6703f69
@BastianLedererIcinga
Remove NoSubjectLink and EventRuleDecorator
62a2794 
They are no longer used anywhere
@BastianLedererIcinga
Remove unused imports
829487f
@BastianLedererIcinga
Cleanup phpstan-baseline
65fe9c0
@BastianLedererIcinga BastianLedererIcinga force-pushed the use-typed-class-attributes branch from d68a217 to 65fe9c0 Compare April 30, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BastianLedererIcinga BastianLedererIcinga BastianLedererIcinga left review comments

@nilmerg nilmerg nilmerg left review comments

@sukhwinder33445 sukhwinder33445 Awaiting requested review from sukhwinder33445

At least 1 approving review is required to merge this pull request.

Assignees

@BastianLedererIcinga BastianLedererIcinga

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use typed class attributes

5 participants

@jrauh01 @lippserd @BastianLedererIcinga @nilmerg @sukhwinder33445