Make incident age field intuitive#169
Closed
raviks789 wants to merge 7 commits into
Closed
Conversation
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
3ce797e to
374a0c7
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
from
1d26d1c to
d4e94a1
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
7 times, most recently
from
473161f to
d35dd96
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
from
d4e94a1 to
aab2015
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
3 times, most recently
from
23933ea to
5e55ce6
Compare
sukhwinder33445
requested changes
Apr 24, 2024
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Cannot save the incident age to db.
raviks789
force-pushed
the
event-rule-config-enhancement
branch
3 times, most recently
from
04e9fb6 to
18bbc0a
Compare
Contributor
Author
As discussed offline, this is a known issue in this PR that does not need to be fixed. As the PR #170 makes it obsolete. |
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
18bbc0a to
5a0ac30
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
2 times, most recently
from
6c487ee to
283d33d
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
4 times, most recently
from
b72e697 to
37782fa
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
from
283d33d to
645ab3e
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
2 times, most recently
from
513d3a4 to
6243671
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
from
9160ed0 to
faa3825
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
6243671 to
c2dc61d
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
5 times, most recently
from
2a73b7d to
2074e7f
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
c2dc61d to
71fcd7f
Compare
raviks789
force-pushed
the
make-incident-age-field-intuitive
branch
7 times, most recently
from
81167fb to
72942bf
Compare
raviks789
force-pushed
the
event-rule-config-enhancement
branch
from
71fcd7f to
2b31a5a
Compare
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
- It is still possible to set
0.5m, yes we cannot save it, or when reloading it becomes1, but it is a bug. You can simply add a default attributevalueto the$valUnitelement to prevent this behaviour. - There is extra margin.
sukhwinder33445
requested changes
May 16, 2024
Contributor
Author
This should be fixed now. |
Member
|
Obsoleted by #159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.