notifications: drop obsolete event fields & introduce new ones#199
Open
yhabteab wants to merge 2 commits into
Open
notifications: drop obsolete event fields & introduce new ones#199yhabteab wants to merge 2 commits into
yhabteab wants to merge 2 commits into
Conversation
ab64a50 to
1be9a41
Compare
Member
|
While I am generally okay with this change, the failing compatibility CI jobs underline a certain question: Do we want to merge this directly into |
Member
Author
|
Just in case we need to release IGL in the meantime without such changes, we can also use a separate branch till all the consumers are adapted to these changes as well. |
Member
Author
|
I've changed the base branch now. |
oxzi
previously approved these changes
May 4, 2026
These are now obsolete and won't be used by Notifications anymore.
1be9a41 to
5024937
Compare
Member
Author
|
After a short discussion with @nilmerg offline, we agreed to rename the HTTP header to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops the obsolete
extra_tags,rule_ids, andrules_versionfields from the notificationEventstruct as they are no longer used by Icinga Notifications since Icinga/icinga-notifications#418. It also introduces two new fieldscomplete_relationsandrelationsto theEventstruct, which are going to be used by the new Notifications rule evaluation engine to determine which rules match a given event. Additionally, it adds a new HTTP headerX-Icinga-Reject-If-Relations-Incompleteto be used by the Notifications API to indicate whether the client supports attribute negotiation. The name of the header is not final and is open for discussion.