Repository navigation
Add selected-text voice editing on macOS - #137
Merged
Merged
Conversation
Extract the desktop selected-text voice editing from #124 so it no longer depends on the iOS keyboard stack (#121) and lands directly on main. Selected-text voice edits replace the frozen selection automatically after generation and capture drain, through the existing Session / target lease / output transaction. The HUD shows only progress, cancellation and a confirmed one-use Restore. Esc cancels before delivery; Command-Option-Z restores the confirmed original once. Remote-model disclosure is required before selected text is sent, and selected content stays out of generic history. Source: de89534, 72dc402, 1eae672, 27ffc8c, da43ec8 on research/voicecursor-voice-editing-20261008, rebased onto origin/main. Left out on purpose (still in #124 / #121): UtterMobile, UtterKeyboardBridge, iOS/ targets and the mobile selection scripts; the offline-sandbox build and evidence tooling (build-app.sh options, guarded-offline-build.py, capture-candidate.py). Merge decisions against main: - Secure input now refuses every write, including the clipboard-only copy, on the Chromium web-editor path too. The main-side test that expected a clipboard copy under secure input is updated to match. - Test doubles on main (UpdateFakeExecution) gained the new SessionExecutionService requirements. Co-authored-by: Cursor <cursoragent@cursor.com>
IchenDEV
marked this pull request as ready for review
October 26, 2026 07:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Desktop selected-text voice editing, extracted from #124 so it lands on
mainwithout the iOS keyboard stack (#121).A selected-text voice edit replaces the frozen selection automatically after generation and capture drain, through the existing Session / target lease / output transaction. The dark HUD shows only progress, cancellation and a confirmed one-use Restore. There is no candidate preview and no Apply. Ordinary dictation and the original recording controls are unchanged.
Esccancels a shown selected session before delivery.Command-Option-Zrestores the current confirmed original once; hostCommand-Zis untouched. Registrations are scoped to the shown eligible session/receipt and fail closed on conflict.Source commits:
de895347,72dc402f,1eae6726,27ffc8c1,da43ec84onresearch/voicecursor-voice-editing-20261008, rebased onto currentmain.de895347was a merge ofmaininto the iOS branch plus the feature, so the feature delta was computed against the pure merge result.Not included (stays in #124 / #121)
UtterMobile,UtterKeyboardBridge,iOS/and the mobile selection scripts.build-app.shoptions,guarded-offline-build.py,capture-candidate.py.ios.*strings.Decisions to review
testSecureTargetRefusalCannotAutomaticallyCopyEvenWhenPasteIsEnabled).main's Chromium web-editor path (69cb79a) still copied to the clipboard under secure input. The web-editor path now follows the same rule, andtestWebEditorUnderSecureInputOnlyCopiesWithoutPostingKeysbecametestWebEditorUnderSecureInputCommitsNothingAndDoesNotCopy. Reverting to the old behavior is a one-place change inTextDeliveryTransaction.main(UpdateFakeExecution) gained the newSessionExecutionServicerequirements.TextDeliveryTransaction,NativeDeliveryTarget,ScopedOutputService,NativeDesktopHostandLocalizable.stringswere merged as unions of both sides;SessionJobControlkeepsfinalizeCapture(reason:).Verification (local, on
ac0ad14)swift build --build-testsswift test(full)bash scripts/sdlc-checks.shbash scripts/ci-basic-checks.shThe native tests render the real HUD and, with
UTTER_NATIVE_EVIDENCEset, wrote 42 PNGs covering recording, automatic processing, restorable, restore failure and remote disclosure in English/Chinese. The HUD is always dark, so the Aqua and DarkAqua captures are identical. Those captures are content-view renders, not WindowServer composites.Open gates
docs/sdlc/changes/2026-10-08-voice-editing-research/still describes desktop + iOS.platform-evidence.md,rule-context-r11.mdandswiftpm-result-r7.mdarepending approval;offline-unit-r9.mdandsandbox-registration-r8.mdareblocked. Approvals are the owner's; none were changed here.selection_edit.review/apply/original/revised/...strings andapplySelectionEdit.Rollback is a normal revert of the commit; no data migration or user-data reset is involved.