Repository navigation
test: make generation preparation responsiveness deterministic - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Release v0.0.54 failed because its preparation responsiveness test could finish
copying before the heartbeat task ran. Replace the timing probe with the existing
worker entry/exit barrier. The MainActor must respond while real preparation is
held at that barrier; copied bytes and candidate cleanup are still checked.
Internal callbacks default to nil for existing production callers.
SDLC bundle and risk
docs/sdlc/changes/2026-10-16-preparation-responsiveness-test/after checks pass. A future production run requires separate approval.
skipped production are preserved in the upstream signing bundle.
Verification
bash scripts/sdlc-checks.shandbash scripts/ci-basic-checks.sh.swift test --skip-build --skip-update --disable-automatic-resolutionafter building outside the runtime policy with native SwiftPM sandboxing.
1,143 unique XCTest cases, 17 conditional skips, zero failures; one Swift Testing
case passed. Every started/finished identity matches frozen discovery.
All 702 product files and 300 bundle files retain their hashes.
assertion failure without hanging. Exact source restored, rebuilt and passed.
mounted-content verification passed. This local fixture is not notarized or published.
credential/path scan passed. Raw logs remain private.
No UI change. Initial wrapper environment failures and the manifest prewarm
resolution are retained in the committed evidence, with native sandboxing and
privacy controls preserved.
Residual risk and rollback
PR CI and exact-main CI must pass before a new release tag. Production signing,
Apple notarization, Gatekeeper checks and publication remain separate release
outcomes. Revert this scoped commit through a PR to roll back; preserve the
responsiveness requirement and failed immutable tags.
Reviewer focus
The entry callback, actual preparation and deferred exit callback must remain in
the same detached closure. The MainActor snapshot must precede gate release.