Skip to content

Fix mixed decimal notation in local calculator requests - #148

Open
IamAngusU wants to merge 1 commit into
mainfrom
fix/local-calculator-decimals
Open

IamAngusU wants to merge 1 commit into
mainfrom
fix/local-calculator-decimals

Conversation

@IamAngusU

Copy link
Copy Markdown
Owner

Summary

  • Normalize decimal separators per numeric literal, so (4,2 * 10.1) * 3 / 30 + 5 computes exactly 9.242.
  • Accept unambiguous decimal commas in German, English and bare arithmetic; preserve German comma conventions and reject ambiguous thousands-style commas outside that context.
  • Reject grouped/malformed literals without falling back to a model. No eval, shell, network, F-drive dependency, new provider or numeric-budget changes.
  • Update public README and changelog. Shared resolver covers do, chat and MCP.

Verification

  • Reproduced the bug with failing tests before the implementation change.
  • 31 added table-driven decimal cases plus chat/MCP regression coverage.
  • go test -p 2 ./... and go vet -p 2 ./... passed on Windows.
  • Targeted localtools/CLI race tests passed.
  • Decimal normalization fuzz run passed: 458,843 executions in about 21 seconds.
  • Built public CLI and exercised German/English prompts using an isolated configuration with no pool credentials and a dead loopback relay; both returned 9.242. Ambiguous numbers and division by zero remained errors.

No claim of a general autonomous tool-selection loop or GUI/model-quality improvement. Thousands grouping remains deliberately unsupported; result formatting remains decimal-point or exact fraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant