Skip to content

Make bounded agent data flow explicit and profile-aware - #147

Open
IamAngusU wants to merge 10 commits into
mainfrom
fix/agent-profile-classification
Open

IamAngusU wants to merge 10 commits into
mainfrom
fix/agent-profile-classification

Conversation

@IamAngusU

@IamAngusU IamAngusU commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Classify each bounded-agent adapter target by its exact operator-owned profile, matching relay precedence. Previously a named local_only policy rejected an explicitly local profile as a generic remote adapter.
  • Check every allowed profile and the planner independently. A local first profile cannot authorize a remote sibling; tenant denial, cost opt-in, scoped profiles and critical confirmation remain enforced.
  • Clarify structured adapter instructions, source newline preservation, step metadata placement and explicitly contracted sandbox versus arbitrary host execution. No automatic request repair or new execution authority.
  • Correct the bounded-agent documentation's stale statement about the explicit previous-JSON handoff.
  • Require an explicit boolean use_previous in every fresh proposal. Missing/null values previously silently became false, dropping actual tool diagnostics. Saved hash-approved plan representation is unchanged. No dependency is guessed or silently repaired.
  • Add opt-in per-engine ollama_think, requiring an explicit model and token ceiling. Default stays false. Only final responses enter output/tool chains; private reasoning is ignored, missing final output fails, limits and execution bindings remain in force.

Verification

  • Reproduced the local-profile rejection with a failing regression test before fixing it.
  • go test ./...
  • go vet ./...
  • go test -race ./cmd/contextbridge -run Agent -count=1
  • go test -race ./cmd/contextbridge ./internal/bridge -run 'Agent|Ollama.*Thinking|OllamaGenerationRequestsFinal' -count=1
  • Isolated Windows black-box relay → paired worker → scoped adapter roundtrips, including cancellation/cleanup.
  • Real local-model bounded flows exercised exact structured requests, local-only receipts and one-attempt jobs. Model-generated code that failed fixed operator acceptance cases remained failed; orchestration completion is not a correctness claim.

No existing pool configuration or default automatic authority was widened. No general host-shell support is added.

GitHub Actions could not start: runner annotations report that the account is locked due to a billing issue. The passing verification above was run locally; hosted/multi-OS CI is not claimed.

@IamAngusU IamAngusU changed the title Fix bounded-agent adapter profile classification Make bounded agent data flow explicit and profile-aware Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant