Repository navigation
Normalize structured adapter proposals before approval - #146
Merged
Merged
Conversation
Owner
Author
|
Validated exact head 7ea2ce2 on angusu-de: all 12 CI jobs passed (run 37213445110), including Windows/Linux/macOS, race, security, DAST, installers and artifact checks. Both CodeQL analyses passed (run 37213491180). Local unit reproduction failed before the change and passes after it; named-policy HTTP lifecycle still preserves scope and exact request bytes. The separate free-form Qwen4B project evaluation still produced invalid semantic plans; this PR fixes representation handling, not model quality. No invalid live plan was executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a real natural-language agent planning failure: a model may return an adapter request as a JSON object instead of a JSON-encoded string. Normalize only fresh unapproved adapter proposals, before unchanged policy validation and hash binding. Preserve exact numeric IDs without float conversion. Saved plans remain string-only. Unknown envelope/step fields, duplicate keys, scalars, arrays, non-adapter objects, and oversized requests fail closed; adapter payload schema and scoped authority remain the adapter responsibility. Includes negative tests, saved-plan compatibility test and HTTP named-policy lifecycle integration. Local go test ./..., go vet ./..., and targeted race tests pass. CI mirror on angusu-de is triggered separately.