chore(certs): Create an Ansible playbook for generating certificate signing requests#343
Conversation
The requests are always the same
Ansible already has access to the keys and domain name. This avoid duplication and having to copy certificates around to generate new signing request files by hand.
📝 WalkthroughWalkthroughThis pull request migrates certificate signing request generation from static configuration files in the ChangesCertificate management infrastructure migration
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@infra/ansible/site_csr.yml`:
- Around line 7-14: The CSR task using community.crypto.openssl_csr currently
sets common_name from top_level_domain but omits subject_alt_name; update the
task that defines community.crypto.openssl_csr (the block with path,
privatekey_content, country_name, state_or_province_name, organization_name,
organizational_unit_name, common_name) to add a subject_alt_name parameter that
includes a DNS entry for the same top_level_domain (e.g. subject_alt_name:
"DNS:{{ top_level_domain }}"), ensuring the generated CSR contains a DNS SAN
matching common_name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 43c271b8-b866-4156-a925-e0d31d8c76de
📒 Files selected for processing (8)
certs/.gitignorecerts/README.mdcerts/analytics.isis.cclrc.ac.uk/2025-06/analytics_isis_cclrc_ac_uk.cnfcerts/dev-analytics.isis.cclrc.ac.uk/2026-01/dev-analytics_isis_cclrc_ac_uk.cnfdocs-devel/deployment/index.mddocs-devel/readme.mdinfra/ansible/.gitignoreinfra/ansible/site_csr.yml
💤 Files with no reviewable changes (5)
- docs-devel/readme.md
- certs/README.md
- certs/.gitignore
- certs/dev-analytics.isis.cclrc.ac.uk/2026-01/dev-analytics_isis_cclrc_ac_uk.cnf
- certs/analytics.isis.cclrc.ac.uk/2025-06/analytics_isis_cclrc_ac_uk.cnf
Summary
The old method for generating new requests for SSL/TLS certificates was clunky and involved copy the key locally and running an openssl command. This has been replaced with an Ansible playbook that:
Documentation has been updated.
Summary by CodeRabbit
Documentation
Chores