Auto Create thumbnail so Search API will return image_url when publis…

[stevenwinship]

What this PR does / why we need it: SPA not getting image_url through Search API. JSF does get the image_url.

Which issue(s) this PR closes: #11588

• Closes Search API: doesn't return image_url for newly created dataset #11588
• Closes Feature Request: Add imageUrl to Get Dataset API JSON response #11586

Special notes for your reviewer:

Suggestions on how to test this:

With this PR, the behavior should be the same JSF vs the SPA: a thumbnail for the dataset will be auto-selected when the dataset is published; unless a specific thumbnail has already been picked by the author while it was still in draft, OR auto-selection has been disabled on the instance (such as on qa.dataverse.org).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

[coveralls]

Coverage is 24.947% — 11588-search-api-doesnt-return-image-url into develop. No base build found for develop.

[stevenwinship]

I see this after publishing (in Chrome)

[stevenwinship]

This was on Firefox

[stevenwinship]

I see the difference now.

I added the file and immediately pressed publish and I see the image
If I add the file then go back to the search list and select and publish I don't see the image

Is it possible that this is a UI issue? The api doesn't know the sequence of events.

[landreev]

Very interesting! Does the dataset end up with useGenericThumbnail=true in the process?

[stevenwinship]

The issue with the images not showing up following Ellen's workflow was due to a race condition where the thumbnail was being updated via a sql call and the Dataset was being merged via java. If the Dataset merge happened first the sql update would be fine. If the sql update happened first the merge would put back an empty thumbnail. The fix was to add the thumbnail to the dataset so the merge would have it

[landreev]

In my defense, I mentioned in an earlier comment that that was a possibility - that the NativeQuery hack could conflict with the rest of the publish command. 🙂

[ekraffmiller]

It is working as expected now from the frontend, but not sure why the integration test is failing.

[stevenwinship]

It is working as expected now from the frontend, but not sure why the integration test is failing.

I'm testing it now locally. Since they are search tests it could be an index timing issue

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11588-search-api-doesnt-return-image-url

ghcr.io/gdcc/configbaker:11588-search-api-doesnt-return-image-url

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.